← Back to issue list

deps: update cryptography to v39.0

View original Github issue

Metadata

Project
charmcraft
Number
#1024
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #1024 (commit 96f6a183) merged into charmcraft, upgrading cryptography to39.0 and adding needed Rust build deps to snap/snapcraft.yaml; it fixes issue #991 after the author validated builds on all architectures.

Resolution: closed resolved

Reason: Merged as commit 96f6a183 ("deps: update cryptography to v39.0 (#1024)") with3 approving reviewers; the author confirmed all-architecture builds in snap/snapcraft.yaml and merge on 2023-03-29, closing issue #991 ("Dependency on an old version of cryptography").

Evaluated by: mr-cal-bot

No scores available.

Issue body

Since older versions of cryptography now have known security issues, it's more necessary to update. This not only makes that change but also updates the snapcraft.yaml to include the appropriate rust dependencies. Should fix #991

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1024 (commit 96f6a183) merged into charmcraft, upgrading cryptography to39.0 and adding needed Rust build deps to snap/snapcraft.yaml; it fixes issue #991 after the author validated builds on all architectures.
stealth/space-bunny-alpha — closed resolved Merged PR #1024 (commit 96f6a183): bumped cryptography to 39.0 for security fixes and added required Rust build deps to snapcraft.yaml, closing issue #991. Follow-up #1091 (92e93b46) added an arch build workaround.
stealth/space-bunny-alpha — closed resolved Merged PR #1024 as commit 96f6a183, upgrading cryptography to 39.0 and adding required Rust dependencies to snapcraft.yaml; fixes #991.
stealth/space-bunny-alpha — closed resolved Merged #1024 (commit 96f6a183), updating cryptography to 39.0 for security fixes and adding required Rust dependencies to snapcraft.yaml; resolves #991.
qwen/qwen3.6-35b-a3b — — Merged after updating cryptography to v39.0 to address security vulnerabilities and updating snapcraft.yaml for rust dependencies. Delayed until spread tests passed on ppc64el and s390x. Resolves #991.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to cryptography v39.0 to address security vulnerabilities. Updated snapcraft.yaml for rust dependencies and verified cross-architecture builds. Resolves #991.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#991 (confidence 97%)

    The PR body states 'Should fix #991'; that issue is closed by this merge.

  • Related To: canonical/charmcraft#1091 (confidence 72%)

    Follow-up merged PR (92e93b46) adding a snap build workaround so cryptography compiles on all supported architectures, stemming from this work.

Related issues

Issue Project State Summary Similarity
#4033 build(deps): bump cryptography from 3.4 to 39.0.1 snapcraft closed Closed unmerged because cryptography 39.0.1 did not work on every architecture; maintainers cited canonical/charmcraft#1024, and Snapcraft later updated it in #4136 (3fd3e4c52).
87%
#1019 chore(deps): update dependency cryptography to v39 [security] charmcraft closed Renovate PR #1019 (cryptography 3.4.8 -> 39.0.1) was closed unmerged by lengau on 2023-02-15 as superseded by canonical/charmcraft#1024, which merged the same v39.0 bump (commit 96f6a183) and added Rust build deps to snapcraft.yaml.
86%
#1200 build(deps): bump cryptography from 41.0.2 to 41.0.3 charmcraft closed Dependabot's cryptography 41.0.2→41.0.3 bump was closed unmerged as redundant; the same update landed via security PR canonical/charmcraft#1201 (commit 31f7281c).
79%
#1018 build(deps): bump cryptography from 3.4.8 to 39.0.1 charmcraft closed Closed unmerged; the cryptography 39.0 upgrade landed through merged PR #1024 (commit 96f6a183), including required Rust build dependencies.
79%
#6163 build(deps): bump cryptography from 46.0.6 to 46.0.7 snapcraft merged Dependabot bump of cryptography 46.0.6→46.0.7 (CVE-2026-39892 buffer-overflow fix, OpenSSL 3.5.6 wheels) merged into snapcraft via PR #6163, commit a8123a0a8.
78%
#4136 deps: update cryptography dependency snapcraft merged PR #4136 updated the cryptography dependency for CRAFT-1720 and merged into main as commit 3fd3e4c52.
78%
#978 chore(deps): update dependency cryptography to v39 charmcraft closed Renovate PR to bump cryptography 3.4.8 -> 39.0.0 was closed unmerged by lengau (2023-01-19) because cryptography 39 needs Rust >=1.48 unavailable on 18.04/20.04 armhf/arm64/ppc64el/s390x. Later redone manually and merged as #1024 (96f6a183).
76%
#4195 build(deps): bump cryptography from 40.0.2 to 41.0.0 snapcraft merged Merged PR #4195 via commit d8930f173, upgrading cryptography from 40.0.2 to 41.0.0 after confirming Rust 1.65 availability on supported architectures.
76%
#991 Dependency on an old version of cryptography charmcraft closed Resolved by merged PR #1024 (96f6a183), upgrading cryptography from 3.4.8 to 39.0 and adding required Rust build dependencies for supported architectures.
75%
#1056 chore(deps): update dependency cryptography to v39 [security] charmcraft closed Renovate's cryptography 3.4.8->39.0.1 security bump was closed unmerged; maintainer lengau pointed to #1024, which merged as commit 96f6a183 upgrading to 39.0 (plus Rust build deps) and closing #991.
74%