← Back to issue list

move config check from load() to command.run()

View original Github issue

Metadata

Project
charmcraft
Number
#1035
Type
pull request
State
merged
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1035 moved config validation from load() to command.run(), allowing commands that do not require valid charmcraft.yaml or bases to run.

Resolution: closed resolved

Reason: PR #1035 was approved and merged. Commands now invoke self._check_config() only when required configuration is needed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This allowed user to use any commands that do not need a vaild "charmcraft.yaml" or "bases". The command should use self._check_config() to indicate the required content.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1035 moved config validation from load() to command.run(), allowing commands that do not require valid charmcraft.yaml or bases to run.
stealth/space-bunny-alpha — closed resolved Merged PR #1035 moved configuration validation from load() to command.run(), allowing commands that do not need a valid charmcraft.yaml or bases to run.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#1035, moving config validation from load() to command.run() so commands can run without valid charmcraft.yaml or bases when unnecessary.
qwen/qwen3.6-35b-a3b — — Merged changes relocating configuration validation from load() to command.run(). This allows commands to execute without a valid charmcraft.yaml or bases when unnecessary, using self._check_config() for conditional requirement checks. Approved and integrated.
qwen3.6-35b-a3b-mtp-q6 — — Merged: configuration validation moved from load() to command.run(). Commands now invoke self._check_config() only when required, enabling execution without a valid charmcraft.yaml or bases.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.