← Back to issue list

Fix digest check for uploading OCI resource

View original Github issue

Metadata

Project
charmcraft
Number
#1051
Type
pull request
State
closed
Author
carlcsaposs-canonical
Labels
—
Created
Updated
Closed

Current evaluation

PR #1051 proposed correcting OCI digest detection from ':' to '@', but was closed unmerged after 1,291 days without review, CI runs, or a documented resolution.

Resolution: closed stale

Reason: PR #1051 remained pending with no reviewers or CI checks and was eventually closed without being merged or receiving a closing maintainer comment. No resolving commit or superseding work was identified.

Evaluated by: mr-cal-bot

No scores available.

Issue body

`charmcraft upload-resource` fails to upload a local OCI image if the OCI image has a tag (e.g. `charmcraft upload-resource test-application-167531 mysql-image --image dataplatformoci/mysql-and-shell:latest`) I believe this happens because the check for a digest (e.g. `dataplatformoci/mysql-and-shell@sha256:599fe5e5073102dbb0ee3dbb65f049dab44fa9fc251f6835c9990f8fb196a72b`) checks if `:` is in the string instead of checking `@`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #1051 proposed correcting OCI digest detection from ':' to '@', but was closed unmerged after 1,291 days without review, CI runs, or a documented resolution.
stealth/space-bunny-alpha — closed stale Proposed a one-line OCI digest-check fix, but PR #1051 was closed unmerged without review, CI, or a documented replacement.
stealth/space-bunny-alpha — closed stale Proposed replacing ':' with '@' in OCI digest detection, but #1051 was closed unmerged with review pending, no CI, and no documented maintainer resolution.
qwen/qwen3.6-35b-a3b — — Closed after fixing the OCI image upload digest check in charmcraft. The validation logic was corrected to check for @ instead of :, resolving failures when uploading tagged images.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The proposed fix addresses a bug where uploading OCI images with tags failed due to incorrect digest validation checking for ':' instead of '@'.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#444 unable to upload oci-image resource from dockerhub using image digest charmcraft closed Closed by maintainer facundobatista as superseded: charmcraft 1.1.1 (in candidate at the time) reworked OCI uploads to push images from the local machine and always reference them by digest, so the reported remote-digest limitation no longer applied.
70%