← Back to issue list

Race condition in store spread tests

View original Github issue

Metadata

Project
charmcraft
Number
#1095
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Store spread-test race flakiness was fixed by commit af7f9b23; PR #1460 later reduced store-test timing sensitivity further in fd5bd6ba.

Resolution: closed resolved

Reason: Commit af7f9b23 (“tests: make store spread tests more robust”) addressed the race between simultaneous store tests. PR #1460 later added related robustness improvements through fd5bd6ba.

Evaluated by: mr-cal-bot

No scores available.

Issue body

https://github.com/canonical/charmcraft/actions/runs/4788865765/jobs/8516125060?pr=1094 This is caused because multiple store tests are running simultaneously. Specifically what's happening here is that the `resources` test is uploading a charm and then checking which revision is on that channel. If another upload completed between those two actions, the test will fail.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Store spread-test race flakiness was fixed by commit af7f9b23; PR #1460 later reduced store-test timing sensitivity further in fd5bd6ba.
stealth/space-bunny-alpha — closed stale Store spread-test flakiness was later addressed by af7f9b23; another related fix, #1460 (fd5bd6ba), reduced timing sensitivity during store processing.
qwen3.6-35b-a3b-mtp-q6 — — Closed without resolution. Concurrent store tests triggered a race condition during charm uploads and revision checks. The issue was abandoned or addressed externally without linked fixes or comments.
qwen/qwen3.6-35b-a3b — — Closed without resolution or linked pull request. The store spread test race condition was abandoned due to prolonged inactivity, with no explicit fix documented.
qwen/qwen3.6-35b-a3b — — Closed without documented resolution. Concurrent store spread tests triggered a race condition during charm uploads and revision checks, but no fix was implemented.
qwen3.6-35b-a3b-mtp-q6 — — Closed without discussion, likely abandoned or fixed by serializing store test executions to prevent concurrent upload races.

Update history

No update history recorded yet.

Related work

  • Related To: charmcraft#1094 (confidence 99%)

    Its failing GitHub Actions run exposed the concurrent-upload race.

  • Related To: charmcraft#1460 (confidence 95%)

    A later robustness change made store spread tests less timing-sensitive.

Related issues

Issue Project State Summary Similarity
#1460 fix(tests): make store spread tests less flaky charmcraft merged Merged PR #1460 as fd5bd6ba, making store spread tests less timing-sensitive and fixing flaky upload/release checks in #1429.
75%