pydantic: split base and charmcraft config models
Metadata
Current evaluation
Merged as commit 17ad0211: common Pydantic models moved to basic.py, and the Charmcraft config moved to charmcraft.py and renamed CharmcraftConfig.
Resolution: closed resolved
Reason: PR canonical/charmcraft#1141 was approved and merged into main as commit 17ad0211.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Common models moved to basic.py
Charmcraft Config model moved to charmcraft.py and renamed to CharmcraftConfig to avoid confuse with juju's config.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 17ad0211: common Pydantic models moved to basic.py, and the Charmcraft config moved to charmcraft.py and renamed CharmcraftConfig. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1141 as commit 17ad0211, moving common Pydantic models to basic.py and Charmcraft config to charmcraft.py as CharmcraftConfig to distinguish it from Juju config. | |
| qwen/qwen3.6-35b-a3b | — | — | Approved and merged. Split Pydantic config models by moving common models to basic.py and relocating the Charmcraft config model to charmcraft.py, renaming it to CharmcraftConfig to avoid confusion with Juju config. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Split Pydantic config models: common definitions moved to basic.py, while the Charmcraft config was relocated to charmcraft.py and renamed to CharmcraftConfig to avoid confusion with Juju config. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #323 config: migrate to use pydantic BaseModel | charmcraft | merged | Merged in canonical/charmcraft#323 via commit a68601fa, replacing JSON Schema validation with Pydantic BaseModel and adding Config.unmarshal() and clearer field-based errors. | |
| #1768 Migrate to Pydantic 2 | charmcraft | closed | Migrated Charmcraft to Pydantic 2 via merged PR #1777 (70078b03), with the feature branch merged to main in #1817 (394e6e55). | |
| #1812 pydantic 2 version not always including charm source | charmcraft | closed | Fixed by merged PR #1815 (commit 2a0eb973), restoring default parts for bases charms after the Pydantic 2 migration so source files are packaged. |