← Back to issue list

a couple of fixes for tests

View original Github issue

Metadata

Project
charmcraft
Number
#117
Type
pull request
State
merged
Author
chipaca
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #117 via 4ede0f10, applying two test fixes in commit c491b6dd and resolving #105.

Resolution: closed resolved

Reason: The pull request was approved and merged into main. Its body explicitly states that it fixes #105; the changes landed in c491b6dd through merge commit 4ede0f10.

Evaluated by: mr-cal-bot

No scores available.

Issue body

fixes: #105

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #117 via 4ede0f10, applying two test fixes in commit c491b6dd and resolving #105.
stealth/space-bunny-alpha — closed resolved Merged two test fixes in commit c491b6dd via merge commit 4ede0f10; PR #117 explicitly addressed and closed #105.
stealth/space-bunny-alpha — closed resolved Merged charmcraft PR #117 via merge commit 4ede0f10, applying two test fixes in commit c491b6dd and resolving #105.
stealth/space-bunny-alpha — closed resolved Merged as commit c491b6dd, with two test fixes addressing canonical/charmcraft#105.
qwen/qwen3.6-35b-a3b — — Merged to resolve issue #105. Approved by two reviewers, the pull request implements minor test corrections across two files with a +10/-1 line change.
qwen3.6-35b-a3b-mtp-q6 — — Merged by chipaca, resolving issue #105 with several test fixes. Changes were integrated directly without additional review comments.

Update history

No update history recorded yet.

Related work

  • Related To: charmcraft#105 (confidence 100%)

    PR #117 explicitly identifies #105 as fixed.

Related issues

Issue Project State Summary Similarity
#1738 fix(ci): fix merge event in tests charmcraft merged Merged PR #1738 as commit fce79ccd, correcting merge-event handling in CI tests with a one-line fix.
72%
#461 test: improve test coverage fetch-service merged Merged PR #461 via commit 76d6134, adding 270 lines of tests across three files; all CI checks passed and two reviewers approved.
71%
#1027 tests: fix broken unit test in master snapcraft merged Merged PR #1027 fixed a broken master unit test with a one-line test-only change in commit f53b45563.
71%
#1146 test: fix doc version tests craft-application merged Merged PR #1146 as commit 949d2dfe, correcting documentation-version test failures accidentally introduced by merged PR #1140.
71%
#475 Fixed a test to work ok also when running tests in developer mode. charmcraft merged Merged PR #475, fixing a test so it also passes when the suite runs in developer mode (commit d8b1080e; merge 8ccc05cd).
71%