← Back to issue list

Some changes in preparation for big "include everything but jujuignored" branch.

View original Github issue

Metadata

Project
charmcraft
Number
#118
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged #118 via ea36c9bd, adding a hooks-directory constant and relativise helper, and validating that charm entry points remain inside the project.

Resolution: closed resolved

Reason: PR #118 was merged in commit ea36c9bd, with implementation commit c08651dd. It delivered all three stated preparatory changes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Included here: - put the 'hooks' dir as a constant - introduced a 'relativise' helper, that will be used in the next branch - added a verification in the build command line: the entry point must be inside the project

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #118 via ea36c9bd, adding a hooks-directory constant and relativise helper, and validating that charm entry points remain inside the project.
stealth/space-bunny-alpha — closed resolved Merged #118, adding a hooks-directory constant, a relativise helper, and build validation requiring the entry point to remain inside the project.
qwen/qwen3.6-35b-a3b — — Merged following two reviewer approvals. Introduces a hooks directory constant, a relativise helper, and build command verification to ensure the entry point is within the project. Prepares the codebase for a larger refactoring branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged preparatory changes including a hooks directory constant, a relativise helper, and build command entry point validation. These updates support upcoming work on the comprehensive include logic branch.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.