← Back to issue list

Update to pydantic-yaml >= 1.0

View original Github issue

Metadata

Project
charmcraft
Number
#1194
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

pydantic-yaml 1.x integration was completed in commit 22c1a49f during Charmcraft's Pydantic 2 migration, after PR #1191 was closed unmerged.

Resolution: closed resolved

Reason: PR #1191's automated 1.1.0 bump could not merge because v1 required manual API changes. Commit 22c1a49f later incorporated the required pydantic-yaml 1.x work in Charmcraft's mainline Pydantic 2 migration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done 1.x has some changes that require some small changes: https://github.com/canonical/charmcraft/pull/1191 ### Why it needs to get done So we can depend on a solid release version.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved pydantic-yaml 1.x integration was completed in commit 22c1a49f during Charmcraft's Pydantic 2 migration, after PR #1191 was closed unmerged.
stealth/space-bunny-alpha — closed superseded Closed as superseded by the pydantic-yaml v1 work in PR #1191; that PR was later closed unmerged, so no direct v1 update was delivered.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #1191, which implements the necessary updates for pydantic-yaml 1.0.
qwen/qwen3.6-35b-a3b — — Fixed via merged pull request #1191. The pydantic-yaml dependency was updated to version 1.0 or higher after implementing the required code adjustments for the new major version, enabling a stable dependency release.
qwen/qwen3.6-35b-a3b — — Closed after PR #1191 merged, applying the necessary updates to support pydantic-yaml version 1.0 and above. The dependency upgrade to a stable release was completed.
qwen3.6-35b-a3b-mtp-q6 — — Addressed by updating pydantic-yaml to >=1.0 per PR #1191, and closed as resolved.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1191 (confidence 100%)

    Proposed the pydantic-yaml 1.1.0 update but was closed unmerged because manual integration was required.

  • Likely Fixed By: canonical/charmcraft@22c1a49f (confidence 90%)

    Mainline Pydantic 2 migration containing the required pydantic-yaml 1.x integration.

Related issues

Issue Project State Summary Similarity
#499 Update to pydantic-yaml >=1.0.0 craft-parts closed The pydantic-yaml 1.x migration was bypassed when PR #811 removed the unnecessary dependency in commit 1debce16, after PR #498 had temporarily frozen it below 1.0.
87%
#1191 chore(deps): update dependency pydantic-yaml to v1 charmcraft closed pydantic-yaml 1.1.0 was not merged; PR #1191 was closed on 2023-07-26 because manual integration was required, and Renovate then ignored future 1.x updates.
77%
#164 chore(deps): update dependency pydantic-yaml to v1 craft-application closed pydantic-yaml 1.x update PR #164 was closed unmerged; Renovate marked the update as ignored.
75%
#971 chore(deps): update dependency pydantic-yaml to v0.9.0 charmcraft closed The pydantic-yaml 0.9.0 bump was closed unmerged after receiving no reviews or CI; a later 1.x migration completed in commit 22c1a49f via #1194.
75%
#159 setup: pin pydantic-yaml and pydantic versions (CRAFT-718) craft-parts merged Merged in #159 via 0226365f, pinning pydantic-yaml 0.4.2 and pydantic 1.9.0 to restore compatibility and fix #158.
74%
#841 Incorrect extra set on pydantic-yaml craft-parts closed Fixed by merged PR #811 (commit 1debce16), which removed the unnecessary pydantic-yaml dependency and its nonexistent pyyaml extra.
74%
#645 chore(deps): update dependency pydantic-yaml to v1 craft-parts closed Closed unmerged after 974 days; the dependency remained below v1 and was later removed by merged PR #811 (commit 1debce16).
73%
#49 deps: freeze pydantic-yaml < 1.0 craft-application merged Merged PR #49 as commit 97c620ab, capping pydantic-yaml below 1.0 to avoid potentially breaking dependency releases.
72%
#498 deps: freeze pydantic-yaml <1.0.0 craft-parts merged Merged PR #498 as 5b463227, capping pydantic-yaml below 1.0.0 to avoid breaking API changes pending the refactor tracked in #499.
72%
#519 deps: freeze pydantic-yaml <1.0.0 (#498) craft-parts merged Merged PR #519 as cf61a4f6, cherry-picking 5b463227 from #498 to cap pydantic-yaml below 1.0.0 and avoid breaking API changes pending refactoring.
72%