← Back to issue list

The "release" command must not guess the revision

View original Github issue

Metadata

Project
charmcraft
Number
#127
Type
issue
State
closed
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Closed without implementation. The proposal to mandate explicit revision parameters for the release command was abandoned in favor of automatic release-at-upload functionality detailed in issue #126.

Suggested action:

No scores available.

Issue body

Currently the "release" command does not requires a revision, for simplicity as the user just pushed something to the store, and most probably will want to release that revision. This is dangerous, as there's the race condition of a CI or anything pushing *another* revision to the Store in the middle. So we need to remove this automatic behaviour, and the revision will need to be always specified (so probably this will migrate from being an option to a mandatory parameter: ``` charmcraft release 17 edge ``` OTOH, if the user want to do this in a simpler way, she could just release at the moment of uploading, and charmcraft will take care automatically, see #126 .

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without implementation. The proposal to mandate explicit revision parameters for the release command was abandoned in favor of automatic release-at-upload functionality detailed in issue #126.
qwen/qwen3.6-35b-a3b Superseded by issue #126. The proposal to mandate explicit revision parameters for the release command was replaced by an automatic upload-time release workflow to prevent race conditions.
qwen/qwen3.6-35b-a3b Closed without comments. The proposal to require an explicit revision parameter for the release command to prevent race conditions was implemented, though no explicit resolution is documented.
qwen3.6-35b-a3b-mtp-q6 Closed and superseded by issue #126. The proposal to mandate revision parameters for the release command was abandoned in favor of automatic release handling during upload.
qwen3.6-35b-a3b-mtp-q6 The proposal to mandate explicit revisions for the release command was closed without implementation. The auto-guess behavior was likely superseded by alternative workflows, such as releasing during upload, as referenced in issue #126.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#149 make revision a positional argument to release charmcraft merged Merged changes making revision a positional argument to the release command, resolving issue #127. Approved by two reviewers with minimal modifications across three files.
70%