← Back to issue list

Respect the symlink even if it's a directory when building.

View original Github issue

Metadata

Project
charmcraft
Number
#131
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged a pull request updating the build process to respect symlinks pointing to directories. Approved by three reviewers, passed CI checks, and modified two files with 85 additions and 15 deletions.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a pull request updating the build process to respect symlinks pointing to directories. Approved by three reviewers, passed CI checks, and modified two files with 85 additions and 15 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged a change ensuring symlinks pointing to directories are correctly followed during the build process. Authored by maintainer facundobatista, the update was integrated directly without conflicts or additional review.
qwen3.6-35b-a3b-mtp-q6 Merged. The pull request updated the build system to correctly respect directory symlinks. Authored by maintainer facundobatista, the change was integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3370 repo: address issue with fix_symlink() when pointed at directory snapcraft merged Merged fix addressing fix_symlink() crashes when targeting directories. Updates behavior to warn about dangling symlinks, includes refactoring and documentation, and was approved by reviewers prior to merge.
73%
#3497 repo: fix regression in fix_symlink() snapcraft merged Merged a fix for a regression in fix_symlink() where copied files retained stale symlinks. The update ensures symlinks correctly point to new files and adds spread tests for relative and host copy scenarios. Approved by two reviewers and passed CI.
73%
#117 fix: skip symlinks in md5sums debcraft merged Merged a fix that skips symlinks in md5sums. Approved by two reviewers, the change modifies two files with six added lines. CI checks passed aside from a non-blocking OSV-scanner failure.
71%
#215 packages: fix symlink normalization craft-parts merged Merged a fix for symlink normalization that replaces Path.relative_to() with os.path.relpath() to correctly resolve parent path components. Approved by reviewer and passed CI checks.
70%