← Back to issue list

Respect the symlink even if it's a directory when building.

View original Github issue

Metadata

Project
charmcraft
Number
#131
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #131 as commit 6f36923a (implementation 53e92d41), updating Charmcraft builds to respect directory symlinks.

Resolution: closed resolved

Reason: PR #131 was approved and merged into main as 6f36923a. Commit 53e92d41 changed build handling so symlinks to directories are respected rather than traversed as directories.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #131 as commit 6f36923a (implementation 53e92d41), updating Charmcraft builds to respect directory symlinks.
stealth/space-bunny-alpha — closed resolved Merged PR #131 updated Charmcraft builds to respect directory symlinks in implementation commit 53e92d41, merged as 6f36923a.
stealth/space-bunny-alpha — closed resolved Merged PR #131 updated Charmcraft’s build process to respect directory symlinks; merged as commit 6f36923a with implementation commit 53e92d41.
qwen/qwen3.6-35b-a3b — — Merged a pull request updating the build process to respect symlinks pointing to directories. Approved by three reviewers, passed CI checks, and modified two files with 85 additions and 15 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged a change ensuring symlinks pointing to directories are correctly followed during the build process. Authored by maintainer facundobatista, the update was integrated directly without conflicts or additional review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#260 Can't include symlinked file into built charm charmcraft closed Resolved by Charmcraft’s craft-parts build flow in PR #458 (implementation 437dab55, merge 9dc20872), enabling build-time handling of linked project files.
76%
#1079 Do not ignore symlinks to external files charmcraft closed Symlinks to files outside the charm project were skipped during packing. Closed as resolved: PR #2836 (commit e06d40c1) added opt-in CHARMCRAFT_EXPERIMENTAL_MONOREPO, mounting the enclosing git repo root into the build instance; shipped in Charmcraft 4.5 with docs and spread tests.
74%