← Back to issue list

feat(craft-app): Add craft-application compatible models

View original Github issue

Metadata

Project
charmcraft
Number
#1328
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged addition of craft-application compatible models to craft-app. Approved by two reviewers, the change adds 1540 lines across 18 files. Authored by maintainer lengau.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged addition of craft-application compatible models to craft-app. Approved by two reviewers, the change adds 1540 lines across 18 files. Authored by maintainer lengau.
qwen3.6-35b-a3b-mtp-q6 Merged into main branch. Added craft-application compatible models to craft-app. The maintainer integrated the change directly without review comments or discussion.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer-submitted pull request adding craft-application compatible models to craft-app. The change was accepted and integrated without discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1330 feat(craft-app): Add craft-application services charmcraft merged Merged feat(craft-app): Add craft-application services. Approved by two reviewers, the change modified 56 files with 2143 additions and 230 deletions. The author fixed changelist misalignments causing spread test failures before merge.
79%
#4560 feat(craft-application): initial support snapcraft merged Merged initial craft-application support, acting as a fallback to existing logic. Approved by two reviewers with no unresolved comments. Changes affect 40 files, adding 887 lines and removing 197. Additional features are planned.
79%
#2 craft-application specification craft-application merged Merged the craft-application specification update by maintainer lengau. The change modified eight files, removing 108 lines and adding 22. No formal review or CI checks were recorded prior to merge.
76%
#1563 fix: breaking changes from craft-application main charmcraft merged Merged to resolve breaking changes from craft-application main. Approved by two reviewers, the update modified five files (+46/-26 lines) and was successfully integrated into the codebase.
74%
#1454 build: update craft-application charmcraft merged Merged after updating the craft-application dependency and adjusting test constants. Approved by two reviewers with no unresolved comments. Changes affect three files with minor line adjustments.
73%
#856 refactor: use craft-application 5 rockcraft merged Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed.
72%
#1399 feat: craft-application rebase charmcraft merged Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests.
72%
#4573 build(deps): use craft-application from main branch snapcraft merged Merged dependency update switching to craft-application from the main branch. Approved by two reviewers, passed CI, and resolved linter and coverage notes. Changes modified 8 files with 65 additions and 45 deletions.
71%
#1544 feat: update charmcraft to use craft-application from main charmcraft merged Merged update to use craft-application from main. Approved by one reviewer, modifying 23 files with 302 additions and 226 deletions. Targets main branch for craft-application 2.0.
71%
#1596 build(deps): use craft-application 2.0.0 charmcraft merged Merged dependency update to upgrade craft-application to 2.0.0. Approved by two reviewers, the change modified 13 files with 50 additions and 32 deletions.
71%