chore(deps): update ruff and fix new linting errors
Metadata
Current evaluation
Ruff pre-commit hook was bumped and resulting lint errors auto-fixed across 10 files (+40/-37). PR #1347 was merged by lengau on 2023-10-23 as commit 34018724.
Resolution: closed resolved
Reason: The pull request itself was merged into main as commit 34018724, with review approval from two reviewers; the discussion thread closed out with lengau confirming S603/S607 rules are not yet enabled for Charmcraft, deferring them to a future linting-rules update.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Ruff pre-commit hook was bumped and resulting lint errors auto-fixed across 10 files (+40/-37). PR #1347 was merged by lengau on 2023-10-23 as commit 34018724. | |
| stealth/space-bunny-alpha | — | closed resolved | Updated Ruff and fixed new linting errors, mainly through autoformatting across 10 files; merged in canonical/charmcraft#1347 as commit 34018724. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged update to the ruff dependency that resolved new linting errors, primarily via auto-formatting. Maintainer lengau confirmed S603 and S607 security rules remain disabled for Charmcraft but may be enabled in future linting updates. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1825
(confidence 72%)
Follow-up Ruff lint/autofix PR in the same repo ('style(lint): fix ruff 0.6.0 linting errors', merged as 7aa2965b) — same recurring pattern of toolchain bumps requiring lint fixes.
-
Related To:
canonical/craft-providers#624
(confidence 55%)
Sibling Canonical craft repo doing the equivalent 'fix ruff 0.6.0 linting errors' bump, illustrating the shared linting rollout across the craft project family.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #115 chore(deps): update ruff and fix linting issue | craft-application | merged | Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking. | |
| #119 chore(deps): update dependency lint/ruff to v0.0.284 | starbase | merged | Renovate dependency bump PR #119 (lint/ruff 0.0.272 -> 0.0.284 in the ruff pre-commit hook) was approved and merged into main as commit be3ae62; +1/-1 line, no source changes. | |
| #230 chore(deps): update dependency lint/ruff to v0.1.15 | craft-cli | merged | Renovate PR merged (commit e68b0c7), bumping the ruff lint hook from 0.1.14 to 0.1.15 in .pre-commit-config.yaml; approved by two reviewers with no CI failures. | |
| #1346 chore(deps): update dependency ruff to v0.1.1 | charmcraft | closed | Renovate's ruff 0.0.282->0.1.1 bump PR was closed unmerged by lengau as superseded by #1347, which updated the ruff pre-commit hook and auto-fixed new lint errors (merged 2023-10-23, commit 34018724). | |
| #190 chore(deps): update dependency lint/ruff to v0.2.0 | craft-application | merged | Renovate upgraded lint/ruff from 0.1.14 to 0.2.0; PR #190 was approved and merged in commit 9d7306ca. | |
| #181 chore(deps): update dependency lint/ruff to v0.2.0 | starbase | merged | Merged PR #181, updating lint/ruff from 0.1.14 to 0.2.0; landed as commit 5a0b0ea. | |
| #214 chore(deps): update dependency lint/ruff to v0.1.7 | craft-cli | merged | Merged PR #214 upgraded lint/ruff from 0.1.6 to 0.1.7 in commit 3a63abd. | |
| #36 chore: switch to ruff | craft-platforms | merged | Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files. | |
| #570 chore(deps): update dependency lint/ruff to v0.4.5 | craft-providers | merged | Merged PR #570 as commit d81d5fb, updating lint/ruff from 0.4.3 to 0.4.5. | |
| #543 chore(deps): update dependency lint/ruff to v0.3.4 | craft-providers | merged | Renovate PR #543 was merged, updating lint/ruff from v0.3.2 to v0.3.4 in commit 41a09fe. |