← Back to issue list

chore(deps): update ruff and fix new linting errors

View original Github issue

Metadata

Project
charmcraft
Number
#1347
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.

Suggested action:

No scores available.

Issue body

Most of these changes were done by ruff's autoformatter.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Merged update to the ruff dependency that resolved new linting errors, primarily via auto-formatting. Maintainer lengau confirmed S603 and S607 security rules remain disabled for Charmcraft but may be enabled in future linting updates.
qwen3.6-35b-a3b-mtp-q6 Merged. Updated ruff dependency and resolved newly flagged linting errors, primarily via auto-formatting. S603 and S607 security rules remain disabled but are slated for future updates.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#115 chore(deps): update ruff and fix linting issue craft-application merged Merged into main after two approvals and passing CI. The update refreshed the ruff dependency and resolved a linting issue across two files. Codecov recorded a negligible 0.10% coverage decrease upon merge.
93%
#4417 chore(deps): update ruff to 0.1.1 and fix lint issues snapcraft merged Merged dependency update upgrading ruff to 0.1.1 and resolving linting errors across 19 files. Approved by two reviewers, passed CI, and increased coverage by 0.01%. A newer ruff version was released shortly after merge.
91%
#700 chore: update ruff craft-parts merged Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702.
91%
#214 chore(deps): update dependency lint/ruff to v0.1.7 craft-cli merged Merged an automated dependency update upgrading lint/ruff from v0.1.6 to v0.1.7. Approved by two reviewers, passed CI checks, maintained 94.77% test coverage, and modified a single file before final merge.
90%
#200 chore(deps): update ruff and its configuration craft-application merged Merged an update to ruff and its configuration. Approved by two reviewers with passing CI checks. The change modified one file with five additions and five deletions.
90%
#230 chore(deps): update dependency lint/ruff to v0.1.15 craft-cli merged Merged automated dependency update upgrading lint/ruff from v0.1.14 to v0.1.15. Approved by two reviewers, passed CI checks, and maintained 94.81% test coverage across a single file change.
90%
#165 chore(deps): update dependency lint/ruff to v0.1.7 craft-application merged Merged an automated dependency update for lint/ruff from v0.1.6 to v0.1.7. Approved by two reviewers, passed CI checks, and successfully integrated into the main branch.
89%
#131 chore(deps): update dependency lint/ruff to v0.0.291 starbase merged Successfully merged an automated dependency update that upgraded lint/ruff from v0.0.290 to v0.0.291. The change received reviewer approval, passed all CI checks, and was integrated into the main branch.
89%
#91 chore(deps): update dependency lint/ruff to v0.0.272 starbase merged Merged automated dependency update for lint/ruff from v0.0.269 to v0.0.272. Approved by a reviewer, passed CI checks, and merged without coverage changes.
89%
#130 chore(deps): update dependency lint/ruff to v0.0.290 starbase merged Merged automated dependency update upgrading lint/ruff from v0.0.285 to v0.0.290. Approved by one reviewer, passed CI checks, and maintained 100% code coverage.
88%