← Back to issue list

Deprecate charmhub config in charmcraft.yaml

View original Github issue

Metadata

Project
charmcraft
Number
#1359
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Resolved by merged PR #1828 (commit bf0b0751): the charmhub field in charmcraft.yaml is now marked deprecated and emits a warning pointing users to the store env vars. Removal from bases tracked separately in #1787.

Resolution: closed resolved

Reason: PR #1828 ("feat: mark charmhub parameter as deprecated") was merged as commit bf0b0751 and explicitly fixes #1359. In charmcraft/models/project.py the Project.charmhub field is now annotated with a pydantic `deprecated=` message directing users to STORE_API_ENV_VAR/STORE_STORAGE_ENV_VAR/STORE_REGISTRY_ENV_VAR, and the _warn_charmhub_deprecated model validator emits that warning to the user.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done If a charmcraft.yaml file contains a charmhub config, let the user know about the change. Possibly error out store commands? ### Why it needs to get done We're using an environment variable instead.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved by merged PR #1828 (commit bf0b0751): the charmhub field in charmcraft.yaml is now marked deprecated and emits a warning pointing users to the store env vars. Removal from bases tracked separately in #1787.
stealth/space-bunny-alpha — closed resolved The charmhub field in charmcraft.yaml was marked deprecated by merged PR #1828, completing the requested deprecation notice.
qwen3.6-35b-a3b-mtp-q6 — — Superseded and deferred to Charmcraft 3.x. The charmhub config deprecation notice remains pending, while PR #1787 addresses removal from future bases.
qwen/qwen3.6-35b-a3b — — Closed as deferred. The charmhub config deprecation notice remains pending for Charmcraft 3.x, with removal tracked in #1787.
qwen/qwen3.6-35b-a3b — — Deprecating charmhub config in charmcraft.yaml was deferred. Maintainers noted the notice remains pending for Charmcraft 3.x, while PR #1787 was introduced to remove it from future bases instead of immediate implementation.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #1787 for future bases, but the charmhub config deprecation warning and store command errors remain unimplemented in Charmcraft 3.x.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#1828 (confidence 99%)

    Merged PR that added the pydantic `deprecated=` marker and the _warn_charmhub_deprecated validator; PR body states it fixes #1359.

  • Related To: canonical/charmcraft#1787 (confidence 92%)

    Follow-up referenced by lengau in the closing comment: removing the charmhub config from the project spec/future bases, now closed (partially via PR #2659).

Related issues

Issue Project State Summary Similarity
#1828 feat: mark charmhub parameter as deprecated charmcraft merged Merged PR #1828 as commit bf0b0751: the charmhub parameter is deprecated, emits a warning, and directs users to store-related environment variables. Fixes #1359.
78%
#1787 Remove charmhub config from charmcraft.yaml spec charmcraft closed Partially resolved: merged PR #2659 (0e45762b) removed charmhub from the reference; PR #2499 remains open to remove it from the generated spec.
77%
#2499 Remove charmhub config from charmcraft.yaml spec charmcraft closed Removed charmhub config from charmcraft.yaml spec, added a validator to allow it only for legacy bases (ubuntu@24.04 or lower), and updated the JSON schema. Resolved in #2499.
75%