← Back to issue list

fix: ignore empty requirements lines

View original Github issue

Metadata

Project
charmcraft
Number
#1407
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged to resolve issue #1261 by ignoring empty lines in requirements files. Approved by three reviewers, the change updates two files with a two-line addition and one deletion.

Suggested action:

No scores available.

Issue body

Fixes #1261

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to resolve issue #1261 by ignoring empty lines in requirements files. Approved by three reviewers, the change updates two files with a two-line addition and one deletion.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that ignores empty lines in requirements files, resolving issue #1261. The change was authored by maintainer cmatsuoka and integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that ignores empty lines in requirements files, resolving issue #1261. The change prevents parsing errors from blank dependency entries.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1365 fix: ignore empty requirements lines charmcraft merged Merged a fix that ignores empty lines in requirements files, resolving issue #1261. Approved by two reviewers. The change modifies two files with a two-line addition and one deletion.
98%
#797 Removed the --requirements option for build and pack commands (CRAFT-787). charmcraft merged Merged after removing the --requirements option from build and pack commands, resolving issue #657. Approved by one reviewer. Changes span six files, deleting 315 lines and adding 16.
74%
#1251 cli: remove empty lines in the unclean parts message snapcraft merged Merged a change removing empty lines from the CLI unclean parts message to match UI formatting. Approved by one reviewer, updating two files with eight additions and eight deletions.
70%
#1266 tests(spread): requirements dependencies charmcraft merged Merged following approval by two reviewers. Introduces regression tests for requirements file and dependency combinations, resolving issue #1179. The change modifies five files, adding 149 lines and removing one.
70%