← Back to issue list

`charmcraft pack` fails with a false positive on the summary check

View original Github issue

Metadata

Project
charmcraft
Number
#1568
Type
issue
State
closed
Author
DnPlas
Labels
—
Created
Updated
Closed

Current evaluation

Summary validation was raised from 78 to 200 characters, accommodating existing charms. PR charmcraft#1585 implemented the change but was closed unmerged after resolution.

Resolution: closed resolved

Reason: Charmcraft now uses a 200-character maximum for charm summaries instead of 78 characters, resolving the compatibility problem. PR charmcraft#1585 directly implemented this change, although it was closed unmerged after the issue had been resolved.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description Running `charmcraft pack` on a charm with a [`charmcraft.yaml`](https://github.com/canonical/istio-operators/blob/main/charms/istio-pilot/charmcraft.yaml) file without a summary fails with msg: ``` charmcraft pack -v Starting charmcraft, version 2.5.5.post96+g26e3f02 Logging execution to '/home/dplascen/.local/state/charmcraft/log/charmcraft-20240301-124953.845091.log' Bad charmcraft.yaml content: - ensure this value has at most 78 characters (in field 'summary') Full execution log: '/home/dplascen/.local/state/charmcraft/log/charmcraft-20240301-124953.845091.log' ``` ### To Reproduce 1. Install charmcraft from latest/edge channel 2. `chamrcraft pack -v` a charm with no `summary` in its `charmcraft.yaml` file. You could use [this one](https://github.com/canonical/istio-operators/tree/main/charms/istio-pilot) 3. Observe the error ### Environment * Ubuntu 20.04 and 22.04 * charmcraft latest/edge ### charmcraft.yaml ```shell type: charm bases: - build-on: - name: "ubuntu" channel: "20.04" run-on: - name: "ubuntu" channel: "20.04" parts: charm: charm-python-packages: [setuptools, pip, jsonschema, cryptography, cffi] build-packages: [git, rustc, cargo, libffi-dev, libssl-dev, pkg-config] istioctl: plugin: dump source: https://github.com/istio/istio/releases/download/1.17.3/istioctl-1.17.3-linux-amd64.tar.gz source-type: tar ``` ### Relevant log output ```shell charmcraft pack -v Starting charmcraft, version 2.5.5.post96+g26e3f02 Logging execution to '/home/dplascen/.local/state/charmcraft/log/charmcraft-20240301-124953.845091.log' Bad charmcraft.yaml content: - ensure this value has at most 78 characters (in field 'summary') Full execution log: '/home/dplascen/.local/state/charmcraft/log/charmcraft-20240301-124953.845091.log' ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Summary validation was raised from 78 to 200 characters, accommodating existing charms. PR charmcraft#1585 implemented the change but was closed unmerged after resolution.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #1597 in commit ac159e49, raising the charm summary limit from 78 to 200 characters after the 78-character restriction proved too restrictive.
stealth/space-bunny-alpha — closed resolved The summary validation limit was raised from 78 to 200 characters. PR #1585 implemented the change but was closed unmerged after the issue was resolved.
qwen3.6-35b-a3b-mtp-q6 — — The false positive validation error stemmed from a strict 78-character summary limit. The limit was increased to 200 characters to accommodate existing charms. The issue is closed, with follow-up PRs required to trim summaries on a few affected charms.
qwen/qwen3.6-35b-a3b — — Increased the summary validation limit from 78 to 200 characters to accommodate existing charms, as Charmhub has no hard limit. Several charms with excessively long summaries were flagged for shortening.
qwen/qwen3.6-35b-a3b — — Resolved by increasing the summary validation limit from 78 to 200 characters to accommodate existing charms. Follow-up pull requests were opened to shorten summaries for specific charms exceeding the new threshold.
qwen3.6-35b-a3b-mtp-q6 — — charmcraft pack incorrectly enforced a 78-char summary limit. Maintainers resolved this by setting a 200-char limit for charms. Validation will be updated, and PRs will be opened for affected charms to shorten their summaries.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: charmcraft#1585 (confidence 90%)

    Implemented the 200-character summary limit; the PR was later closed unmerged after resolution.

Related issues

No related issues found above the similarity threshold.