fix: reorganise charmcraft.yaml preprocessing
Metadata
Current evaluation
Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines).
Suggested action: —
No scores available.
Issue body
This makes a few related changes:
1. Extensions are applied on the rawest charmcraft.yaml data we have
2. Charms with a "bases" key (not just bundles) get a default part.
3. Always expect a dictionary for parts.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix reorganizing charmcraft.yaml preprocessing. Extensions now apply to raw data, charms with bases keys receive a default part, and parts are strictly enforced as dictionaries. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes reorganizing charmcraft.yaml preprocessing. Extensions now apply to raw data, charms with a bases key receive a default part, and parts are strictly expected as dictionaries. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #289 fix: fix issues found in common.mk with charmcraft | starbase | merged | Merged a fix for charmcraft issues in common.mk. Approved by two reviewers with zero unresolved comments. Changed two files, adding 11 and removing 7 lines. | |
| #2154 docs: replace occurrences of "charmcraft.yaml" and "recipe" | charmcraft | merged | Merged documentation update replacing charmcraft.yaml and recipe with project or project file across 23 files. Approved by two reviewers after minor clarity feedback. Changes span +155/-159 lines. | |
| #471 config: add charm part to documentation (CRAFT-356) | charmcraft | merged | Merged changes adding charm configuration documentation to the configuration schema. Approved by two reviewers with zero unresolved comments. Updated two files with 15 additions and one deletion. Resolves CRAFT-356. | |
| #1556 refactor(tests/spread): test with explicit charmcraft.yaml files | charmcraft | merged | Merged a refactor replacing dynamic charmcraft.yaml manipulation during the prepare step with explicit configuration files. Approved by three reviewers, the change simplifies testing for upcoming variants across nine modified files. | |
| #397 feat: add charmcraft inspector | fetch-service | merged | Merged the charmcraft inspector, verifying charmcraft.yaml existence. Approved by two reviewers, passed CI, and changed 7 files. The author addressed invocation order review comments prior to final merge. | |
| #380 Charmcraft imported improvements | starbase | merged | Merged minor import improvements for Charmcraft across two files. Approved by two reviewers and passed all CI checks before integration. | |
| #91 First pass at 'charmcraft init' | charmcraft | merged | Merged the initial 'charmcraft init' implementation. Approved by two reviewers, the PR adds 1087 lines across 24 files to scaffold charms. README.md, additional options, and interactive prompts require future updates. | |
| #46 New functionality from charmcraft (CRAFT-706). | craft-cli | merged | Merged new charmcraft functionality (CRAFT-706) following approval from two reviewers. The update adds approximately 2000 lines across 13 files, successfully integrating the feature set into the codebase. | |
| #2801 docs: add Charmcraft 4.4 release notes | charmcraft | merged | Added Charmcraft 4.4 release notes. Merged after approval and passing CI checks. Updates four files (+188/-4 lines) to address CHARMCRAFT-711. | |
| #188 Small text cleanups for README and charmcraft help | charmcraft | merged | Merged text cleanups for the README and charmcraft help documentation. Approved by two reviewers, the change updates 13 files to improve clarity while preserving test compatibility. |