← Back to issue list

feat: validate devel bases with craft-application

View original Github issue

Metadata

Project
charmcraft
Number
#1634
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged as unnecessary after craft-application changed; generic devel-base validation had already landed upstream in canonical/craft-application#302.

Resolution: closed superseded

Reason: canonical/craft-application#302 merged the upstream validation for issue #298. The maintainer later stated that charmcraft#1634 no longer needed to land because craft-application changed, pending possible reconsideration after craft-application#348.

Evaluated by: mr-cal-bot

No scores available.

Issue body

For https://github.com/canonical/craft-application/pull/302 and https://github.com/canonical/craft-application/issues/298

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged as unnecessary after craft-application changed; generic devel-base validation had already landed upstream in canonical/craft-application#302.
stealth/space-bunny-alpha — closed superseded Charmcraft PR #1634 was closed unmerged as unnecessary after craft-application changed; upstream devel-base validation landed in craft-application#302.
qwen/qwen3.6-35b-a3b — — Abandoned without merging. Upstream craft-application changes made the validation unnecessary. The author noted the work may be revisited once craft-application issue #348 is resolved.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. Upstream craft-application changes made the PR unnecessary for now. May be revisited once craft-application issue #348 is resolved.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-application#302 (confidence 98%)

    Merged upstream implementation of the devel-base validation proposed for Charmcraft.

  • Related To: canonical/craft-application#348 (confidence 95%)

    Maintainer identified this unresolved upstream issue as a possible reason to reconsider the deferred Charmcraft change.

Related issues

Issue Project State Summary Similarity
#532 feat: validate devel bases with craft-application rockcraft closed Closed unmerged after #569 bumped craft-application to 2.7.0, delivering the devel-base validation planned in #532.
94%
#4721 feat: validate devel bases with craft-application snapcraft closed Superseded by canonical/snapcraft#4796, merged as commit 5dad5eb62, which upgraded craft-application to 2.7.0 and adopted its devel-base validation.
89%
#302 feat!: validate devel bases craft-application merged Merged PR #302 as aeae554e, adding Craft-wide validation that development bases use the matching devel build-base and fixing #298 (CRAFT-2675).
80%
#298 Mechanism to handle/promote 'devel' bases craft-application closed Implemented centralized validation for mandatory upstream devel build bases in merged PR #302 (commit aeae554e), avoiding duplicated application logic.
74%
#6 base: craft-application prototype craft-application merged Merged the initial craft-application prototype in canonical/craft-application#6, changing 21 files (+1029/-204); fuller tests were deferred to a follow-up PR.
71%