← Back to issue list

Remove setup.py

View original Github issue

Metadata

Project
charmcraft
Number
#1635
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Removed setup.py in PR #1455 (commit f41e333d), moving packaging and setuptools-scm version handling to pyproject.toml.

Resolution: closed resolved

Reason: Merged commit f41e333d from PR #1455 replaced setup.py with pyproject.toml. The current tree has no setup.py and configures dynamic versioning through setuptools-scm in pyproject.toml.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Remove the setup.py file, adjusting the snap build so it still correctly gets the version from setuptools-scm. This is non-trivial because of the snap build issue, as I haven't figured out a way to do it without making the snap build always report `dev` as the version. ### Why it needs to get done Setup.py is semi-deprecated.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Removed setup.py in PR #1455 (commit f41e333d), moving packaging and setuptools-scm version handling to pyproject.toml.
stealth/space-bunny-alpha — closed stale Closed without a recorded fix or replacement; the only comment is an automated notice creating internal ticket CRAFT-2777, with no linked implementation.
qwen/qwen3.6-35b-a3b — — Superseded by internal Jira tracking (CRAFT-2777) and closed without a fix or merge. Setup.py removal remains pending due to unresolved snap build versioning constraints.
qwen/qwen3.8-27b
Impact: 15
Quick Win: 9
Staleness: 75
Complexity: 40
Confidence: 90
Support Request: 5
close stale Remove setup.py and adjust snap build for version detection. Resolved: setup.py replaced by pyproject.toml in #1455 and removed in #2444; snap build now uses uv pip show for version.
qwen/qwen3.8-27b
Impact: 20
Quick Win: 14
Staleness: 70
Complexity: 30
Confidence: 85
Support Request: 0
close not a bug Task to remove setup.py and adjust snap build to get version from setuptools-scm. setup.py has already been removed (replaced by pyproject.toml in #1455, file deleted in #2444); snap build now uses uv pip show to read the setuptools-scm version.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 50
Confidence: 80
Support Request: 10
needs triage Proposes removing setup.py and adjusting snap build for setuptools-scm versioning. Unlabeled, unassigned, and inactive for ~11 months with no maintainer response.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 30
Confidence: 85
Support Request: 5
close stale Unlabelled task to remove setup.py and adjust snap versioning, created over two years ago with no maintainer engagement in nearly a year. Python packaging standards have evolved, likely rendering this obsolete.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 65
Confidence: 90
Support Request: 10
needs triage Task to remove setup.py and adjust snap build for setuptools-scm versioning. Unlabelled, no maintainer response, inactive for ~10 months, pending triage.

Update history

Date Change
closed

Related work

  • Likely Fixed By: canonical/charmcraft#1455 (confidence 99%)

    PR #1455 was merged as f41e333d with the title "build: replace setup.py with pyproject.toml".

Related issues

Issue Project State Summary Similarity
#1455 build: replace setup.py with pyproject.toml charmcraft merged Merged #1455 in commit f41e333d, replacing setup.py with pyproject.toml and moving packaging metadata and setuptools-scm version handling to the modern build configuration.
81%
#294 ci: migrate setup.py to pyproject.toml craft-providers merged Merged PR #294 in commit 1d4f8ba, completing the setup.py-to-pyproject.toml packaging migration after #293 and advancing #287.
75%
#740 build: replace setup.py and setup.cfg with pyproject.toml rockcraft closed Closed unmerged; its setup.py/setup.cfg-to-pyproject.toml migration was superseded by merged PR #751 in commit bc45bedf.
74%
#293 ci: migrate setup.cfg to pyproject.toml craft-providers merged Merged PR #293 in commit 163c1d7, migrating packaging metadata from setup.cfg to pyproject.toml as part of #287 and building on PR #292.
73%
#782 chore: replace setup.py with pyproject.toml craft-parts closed PR #782 (setup.py to pyproject.toml) was closed unmerged after ~2 years with no review. The same migration landed later via PR #902, commit 5a1a5db0 "build: migrate to pyproject.toml", which removed setup.py/setup.cfg.
71%