← Back to issue list

Don't ignore important files (like version) by default.

View original Github issue

Metadata

Project
charmcraft
Number
#166
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #166 stopped Charmcraft from ignoring author-supplied files such as version by default, via fca3163e (merge 39a7af55).

Resolution: closed resolved

Reason: PR #166 was approved and merged into the main line by commit 39a7af55. Implementing commit fca3163e removes default ignoring of important files while retaining store-managed revision behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #166 stopped Charmcraft from ignoring author-supplied files such as version by default, via fca3163e (merge 39a7af55).
stealth/space-bunny-alpha — closed resolved Merged in charmcraft#166 via fca3163e (merge 39a7af55): stopped ignoring important files such as version by default while keeping revisions store-managed.
qwen/qwen3.6-35b-a3b — — Merged after approval. The change stops ignoring critical files like version by default. Discussion confirmed that while revision is store-managed, version is author-controlled, so the code now preserves user-provided version files instead of overwriting them.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The change stops ignoring important files like version by default. After discussing stale version risks, the maintainer decided to respect existing version files rather than overruling the author.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.