← Back to issue list

fix(test): parse test command arguments

View original Github issue

Metadata

Project
charmcraft
Number
#1686
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged a fix updating the test command to parse arguments directly instead of forwarding them raw to spread. This enables consistent double-dashed long options and improved help messages. Approved by two reviewers, modifying five files with 55 additions and 32 deletions.

Suggested action:

No scores available.

Issue body

Let the test command parse its arguments instead of forwarding them to spread in raw form. This allows us to use consistent double-dashed long options, and have better help messages. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix updating the test command to parse arguments directly instead of forwarding them raw to spread. This enables consistent double-dashed long options and improved help messages. Approved by two reviewers, modifying five files with 55 additions and 32 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that updates the test command to parse arguments directly instead of forwarding them raw to spread. This enables consistent double-dashed long options and improves help message formatting.
qwen3.6-35b-a3b-mtp-q6 Merged a fix enabling the test command to parse its own arguments instead of forwarding them raw to spread. This enables consistent double-dashed long options and improves help message formatting.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#109 Better tested help parsing function, with a bug fixed. craft-cli merged Merged after approval. Improved testing for the help parsing function and fixed a bug where errors were not properly raised when using the --all flag with extra arguments. Changes span two files with 100 additions and 12 deletions.
75%
#738 feat(test): add more spread interactions craft-application merged Merged after approval by two reviewers and passing CI. Adds --shell, --shell-after, and --debug lifecycle arguments to the test command, enabling specific test selection. Integrated with 441 additions across 12 files.
74%
#5375 test: fix command tests snapcraft merged Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
73%
#207 Avoid a duplicated -h/--help option when getting help for a command. charmcraft merged Merged a fix to eliminate duplicate -h/--help options in command help output by disabling ArgumentParser's automatic help flag addition. Existing tests were updated to expose duplicates. Approved by two reviewers and passed CI.
71%
#1322 fix(test): better matching for strict dependencies spread test charmcraft merged Merged a single-line test fix improving matching logic for the strict dependencies spread test. Approved by two reviewers with zero unresolved comments.
70%