← Back to issue list

fix: make fetch-libs + underscores work

View original Github issue

Metadata

Project
charmcraft
Number
#1701
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1701 via commit 3af2c248, fixing fetch-libs handling of underscored library names and resolving #1681.

Resolution: closed resolved

Reason: The approved change was merged as commit 3af2c248. PR #1701 fixes the fetch-libs internal error reported in charmcraft#1681.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #1681

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1701 via commit 3af2c248, fixing fetch-libs handling of underscored library names and resolving #1681.
stealth/space-bunny-alpha — closed resolved Merged PR #1701, fixing fetch-libs compatibility with underscores and resolving issue #1681.
qwen/qwen3.6-35b-a3b — — Merged fix for #1681 resolving fetch-libs compatibility with underscores. Approved by two reviewers, the change updates seven files with 40 additions and 25 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for fetch-libs and underscores compatibility, resolving issue #1681. The maintainer implemented the changes and the pull request was successfully integrated into the codebase.

Update history

No update history recorded yet.

Related work

  • Related To: charmcraft#1681 (confidence 100%)

    This was the issue fixed by the merged PR.

Related issues

Issue Project State Summary Similarity
#1681 `fetch-libs` crashes with an internal error charmcraft closed Fixed by merged PR #1701 (commit 3af2c248), which made fetch-libs handle library names containing underscores and resolved the crash.
83%
#1702 fix: allow fetch-libs to work without logging in charmcraft merged Merged PR #1702 as commit 1da46c8f, allowing fetch-libs to run without logging in and addressing #1681.
77%
#1754 `fetch-libs` has weird error messages when libs aren't available charmcraft closed Fixed misleading fetch-libs errors for unavailable libraries in merged PR #2034 (commit c9b51038), with a clearer missing-library message.
73%
#1700 fix: swap underscores and hyphens in charms & libs charmcraft closed Closed unmerged after 78 days; its underscore-to-hyphen normalization fix was delivered separately by merged PR #1701 in commit 3af2c248.
70%
#1665 feat: add fetch-libs command charmcraft merged Merged PR #1665 added Charmcraft's fetch-libs command; implementation landed in commit 38ea17d6.
70%