← Back to issue list

fix(builder)!: remove single-step non-strict install

View original Github issue

Metadata

Project
charmcraft
Number
#1727
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 51a55f73 and shipped in 3.2, splitting non-strict installs into binary packages, source packages, then requirements and charm libraries to address #1664.

Resolution: closed resolved

Reason: PR #1727 merged as commit 51a55f73, and the resulting fix was released in Charmcraft 3.2. A later reviewer noted it might not fully address every case, but no superseding change to this PR is identified.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This separates out the install step for non strict-dependencies builds as follows: 1. Install from `python-binary-packages` 2. Install (source-only) from `python-packages` 3. Install (source-only) from requirements files and charm libs.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 51a55f73 and shipped in 3.2, splitting non-strict installs into binary packages, source packages, then requirements and charm libraries to address #1664.
stealth/space-bunny-alpha — closed resolved Merged #1727 (51a55f73), splitting non-strict installs into binary packages, source packages, then requirements and charm libraries, to address #1664.
qwen/qwen3.6-35b-a3b — — Merged removal of the single-step non-strict install, splitting it into three steps. The maintainer bypassed CI to merge due to an unrelated test failure, though reviewers noted it does not fully resolve the referenced issue.
qwen3.6-35b-a3b-mtp-q6 — — Merged despite external test failures. Replaces the single-step non-strict install with three phases: binary packages, source packages, and requirements with charm libraries. Reviewers note partial resolution of the original issue.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1664 (confidence 99%)

    The PR addressed this package-ordering issue, which was closed as shipped in 3.2.

  • Related To: canonical/charmcraft#1743 (confidence 95%)

    The PR was merged with protections bypassed because this unrelated Flask extension test failure prevented CI from passing.

  • Related To: canonical/charmcraft#1751 (confidence 95%)

    Merged PR #1751 fixed the Flask extension dependency failure tracked by #1743.

Related issues

Issue Project State Summary Similarity
#1728 fix(builder)!: in strict mode, don't install deps charmcraft merged Merged PR #1728 (c3b69774), making strict builds skip dependency installation and requiring all dependencies to be declared in requirements.
78%