← Back to issue list

feat: [wip] detect charm classes and ops.main() calls

View original Github issue

Metadata

Project
charmcraft
Number
#1820
Type
pull request
State
closed
Author
dimaqq
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged as WIP; its ops.main analysis was superseded by charmcraft#1883, merged as b6fbbe93 to add charmcraft analyse validation for Operator Framework charms.

Resolution: closed superseded

Reason: PR #1820 remained an unintegrated WIP. The relevant validation was later delivered by merged PR #1883 in commit b6fbbe93.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] detect charm class declarations and imports - [x] detect ops.main calls - [x] some negative tests - [ ] integrate into `charmcraft analyse` - [ ] tests against charms on charmhub.io

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged as WIP; its ops.main analysis was superseded by charmcraft#1883, merged as b6fbbe93 to add charmcraft analyse validation for Operator Framework charms.
stealth/space-bunny-alpha — closed stale Closed unmerged as an abandoned WIP; later charmcraft#1883 merged as b6fbbe93, adding charmcraft analyse validation for Operator Framework ops.main() calls.
qwen/qwen3.6-35b-a3b — — Closed without merging. The pull request remained a work in progress, leaving integration into charmcraft analyse and Charmhub tests incomplete. No reviews or CI checks were completed, indicating the feature was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The pull request was abandoned as a work in progress, with integration into charmcraft analyse and external tests left incomplete. No further activity or comments were recorded.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#1883 (confidence 98%)

    Merged replacement implementing ops.main() validation for Operator Framework charms.

Related issues

Issue Project State Summary Similarity
#1883 feat: validate ops.main() call for operator framework charms charmcraft merged Merged as b6fbbe93, adding an analyse linter that verifies Operator Framework charm entrypoints call ops.main() across supported import styles; shipped in 3.3.0.
75%
#1911 feat: use ops.main() type hints charmcraft merged Updated charm templates to require ops 2.17.0 and pass the charm class to typed ops.main(); merged as commit 2fe53628.
70%