← Back to issue list

fix: properly request docker images from docker API

View original Github issue

Metadata

Project
charmcraft
Number
#1854
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #1854 (commit 1d2413a3, CRAFT-3148) merged to fix Docker API image requests, resolving #1760 and reverting the temporary spread-test disablement from #1761. Reporter confirmed the fix on edge/pr-1854.

Resolution: closed resolved

Reason: The PR was merged into main as commit 1d2413a3, fixing the docker:// image resource DockerException in upload-resource and restoring the test disabled by #1761. Following a reported regression on 3.2, the author amended the branch and reporter lucabello confirmed the upload-resource command works (rev 3.2.0.post9+g2460b772).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #1760, reverts #1761 CRAFT-3148

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1854 (commit 1d2413a3, CRAFT-3148) merged to fix Docker API image requests, resolving #1760 and reverting the temporary spread-test disablement from #1761. Reporter confirmed the fix on edge/pr-1854.
stealth/space-bunny-alpha — closed resolved Merged PR #1854 in commit 1d2413a3 fixed Docker API requests for docker:// image resources, resolving #1760 and reverting #1761. The reported upload-resource DockerException was confirmed fixed.
stealth/space-bunny-alpha — closed resolved Merged PR #1854 as commit 1d2413a3, fixing #1760 by reverting #1761 and correctly requesting Docker images. The upload-resource DockerException was confirmed fixed.
qwen/qwen3.6-35b-a3b — — Merged a fix that properly requests Docker images from the Docker API, resolving a DockerException regression. Approved by two reviewers, the update was refined based on user feedback and resolved the reported upload-resource failure.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Resolves upload-resource DockerException on Charmcraft 3.2 by properly requesting images from the Docker API. Reverts #1761, fixes #1760, and verified on the edge/pr-1854 channel.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1760 (confidence 98%)

    The bug issue 'Docker images not properly requested from docker API', closed by this PR via commit 1d2413a3.

  • Related To: canonical/charmcraft#1761 (confidence 95%)

    Prior merged PR (5cbfbab2) that temporarily disabled the failing upload-resource spread test; reverted by this PR.

Related issues

No related issues found above the similarity threshold.