← Back to issue list

feat: add "cargo" to deb build dependencies for charm plugin

View original Github issue

Metadata

Project
charmcraft
Number
#2005
Type
pull request
State
closed
Author
james-garner-canonical
Labels
Created
Updated
Closed

Current evaluation

Adding cargo to deb build dependencies for the charm plugin was closed due to inactivity. A reviewer flagged conflicts with user-managed Rust toolchains and recommended an environment validator. The changes were not merged.

Suggested action:

No scores available.

Issue body

This PR adds `"cargo"` to the charm plugin build dependencies for deb based charms. I don't know if a similar fix is needed for `yum` and `dnf` systems -- review appreciated here. This will prevent various charm-libs from needing to document that including them requires adding `cargo` to `build-packages` in `charmcraft.yaml`, and prevent charmers from having to do this, since `cargo` will be included be default, and python packages requiring a rust compiler to build (e.g. `pydantic`) will work out of the box. See issue: - #2004

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Adding cargo to deb build dependencies for the charm plugin was closed due to inactivity. A reviewer flagged conflicts with user-managed Rust toolchains and recommended an environment validator. The changes were not merged.
qwen3.6-35b-a3b-mtp-q6 Closed due to inactivity. Reviewers flagged potential conflicts with user-installed Rust toolchains and requested environment validation checks. The proposal to auto-include cargo in deb charm builds was abandoned.
qwen3.6-35b-a3b-mtp-q6 Auto-adding cargo to deb build dependencies for the charm plugin was closed due to inactivity. A reviewer flagged potential conflicts with user-managed Rust toolchains and requested environment validation checks. The changes were not merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2004 charm plugin should include rust compiler in build dependencies charmcraft closed Rejected. The team is shifting away from implicit build dependencies to prevent version drift and unexpected failures. Users must explicitly declare cargo and rustc in their charmcraft.yaml parts.
73%