feat: add "cargo" to deb build dependencies for charm plugin
Metadata
Current evaluation
PR #2005 was closed unmerged as stale after a request for Poetry-style validation protecting user-installed Rust toolchains; no resolving commit was merged.
Resolution: closed stale
Reason: The requested changes were not addressed. @lengau asked for Poetry-style environment validation on 2024-12-05, then closed the PR for inactivity on 2025-05-23.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR adds `"cargo"` to the charm plugin build dependencies for deb based charms.
I don't know if a similar fix is needed for `yum` and `dnf` systems -- review appreciated here.
This will prevent various charm-libs from needing to document that including them requires adding `cargo` to `build-packages` in `charmcraft.yaml`, and prevent charmers from having to do this, since `cargo` will be included be default, and python packages requiring a rust compiler to build (e.g. `pydantic`) will work out of the box.
See issue:
- #2004
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #2005 was closed unmerged as stale after a request for Poetry-style validation protecting user-installed Rust toolchains; no resolving commit was merged. | |
| stealth/space-bunny-alpha | — | closed stale | PR #2005 closed unmerged on 2025-05-23 after inactivity. A requested validator was needed to avoid conflicting with Rust toolchains installed via rustup. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged for inactivity after @lengau requested Poetry-style validator checks to protect user-installed Rust toolchains. | |
| stealth/space-bunny-alpha | — | closed stale | Closed as stale on 2025-05-23 after requested changes remained unimplemented. Linked issue charmcraft#2004 was rejected in favor of explicitly declaring cargo and rustc build dependencies. | |
| qwen/qwen3.6-35b-a3b | — | — | Adding cargo to deb build dependencies for the charm plugin was closed due to inactivity. A reviewer flagged conflicts with user-managed Rust toolchains and recommended an environment validator. The changes were not merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed due to inactivity. Reviewers flagged potential conflicts with user-installed Rust toolchains and requested environment validation checks. The proposal to auto-include cargo in deb charm builds was abandoned. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#2004
(confidence 100%)
Originating issue requesting Rust compiler support for the charm plugin; PR #2005 was its proposed implementation.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2004 charm plugin should include rust compiler in build dependencies | charmcraft | closed | Proposal rejected: PR #2005 was closed unmerged after concerns that implicit system Rust packages conflict with Charmcraft's shift to explicit parts and reproducible builds. | |
| #1062 feat: add cargo-use plugin | craft-parts | merged | Merged PR #1062 via commit 6250df05, adding the cargo-use plugin to populate a local Cargo registry for the rust plugin; shipped in 2.8.0. |