fix(models/project): make no parts error explicit
Metadata
Current evaluation
Merged PR #2073 (commit a93a2d91) rejects platform charm projects without parts, fixing the metadata-only charm packing failure in #2055.
Resolution: closed resolved
Reason: PR #2073 was merged as commit a93a2d91. The project model now enforces at least one part for platform charms, resolving #2055.
Evaluated by: mr-cal-bot
No scores available.
Issue body
There were previously edge cases where a platform charm could be declared but the lack of a `parts` key wouldn't be caught. This now enforces at least one part.
Fixes #2055
CRAFT-3851
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2073 (commit a93a2d91) rejects platform charm projects without parts, fixing the metadata-only charm packing failure in #2055. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/charmcraft#2073 (commit a93a2d91), enforcing at least one part for platform charm projects and making the no-parts error explicit; fixes #2055. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix enforcing at least one part in platform charm declarations, resolving an edge case where missing parts were previously uncaught. Closes #2055 and CRAFT-3851. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enforces at least one parts key in platform charms, fixing an edge case where missing parts were uncaught. Resolves #2055 and CRAFT-3851. macOS CI failures were due to external runner issues and resolved. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
charmcraft#2055
(confidence 100%)
PR #2073 explicitly fixes the no-parts packing failure reported in #2055.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2055 `no hooks nor dispatch file` after packing | charmcraft | closed | Fixed by merged PR #2073 (commit a93a2d91): Charmcraft now rejects platform-based charm projects without parts instead of producing an invalid metadata-only charm. | |
| #596 build: don't create implicit part if parts section specified (CRAFT-633) | charmcraft | merged | PR #596 merged (merge commit 0dacae0a, bcbdd278) by cmatsuoka: charmcraft now skips the implicit `charm`/`bundle` part when an explicit `parts:` section exists (CRAFT-633), fixing #590; tests added. |