← Back to issue list

Exercise command parsers.

View original Github issue

Metadata

Project
charmcraft
Number
#211
Type
pull request
State
merged
Author
chipaca
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #211 in commit 6accbe65 made help exit successfully and added coverage for all command parsers, fixing #210.

Resolution: closed resolved

Reason: PR #211 was merged via commit 39575287. Its parser fix and help coverage across every command directly resolved issue #210.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Before this change, asking for help would always return with error. This made testing actually asking for help hard, so we didn't, so we never exercised the actual command parser, so a bug snuck in. This changes things so that help returns with error only when actually in error, and adds a test that asks for help over all commands, meaning we exercise all the parsers, so we would actually catch this bug. Fixes: #210

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #211 in commit 6accbe65 made help exit successfully and added coverage for all command parsers, fixing #210.
stealth/space-bunny-alpha — closed resolved Merged PR #211 as commit 6accbe65 via merge 39575287, fixing help parsing and adding all-command parser coverage for #210.
stealth/space-bunny-alpha — closed resolved Merged as canonical/charmcraft#211 (commit 6accbe65): help now fails only on actual errors, and tests invoke help across all commands to exercise every parser.
qwen/qwen3.6-35b-a3b — — Merged fix for a bug where the help command always returned an error. Updates help logic to only error on actual failures and adds tests exercising all command parsers, resolving issue #210. Approved by two reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix ensuring help commands only return errors when appropriate, resolving a bug that prevented parser testing. Added comprehensive tests to exercise all command parsers, closing issue #210.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#210 (confidence 100%)

    The command-parser bug explicitly identified by this merged PR.

Related issues

No related issues found above the similarity threshold.