← Back to issue list

Charm building and pushing should be libs-aware

View original Github issue

Metadata

Project
charmcraft
Number
#213
Type
issue
State
closed
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

PR #2252 merged as 3118189c added upload-time warnings for locally newer libraries, but #213 was closed with the standalone check-libs command and broader validation still missing.

Resolution: closed stale

Reason: Commit 3118189c implemented only the upload-time warning. A later commenter stated that #2252 closed just half the request because the standalone command and remaining checks were absent, with no follow-up implementation or closing rationale recorded.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The charm's Build and Upload commands must be aware of charmlibs. **When building**: check that all "used libraries from 3rd parties" are locally updated (with a timeout, because of potential network issues), and that the libraries are not locally modified/tainted. **When uploading**: check that all "own libraries" are properly updated in the Store.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #2252 merged as 3118189c added upload-time warnings for locally newer libraries, but #213 was closed with the standalone check-libs command and broader validation still missing.
stealth/space-bunny-alpha — closed stale PR #2252 (commit 3118189c) merged partial upload-time library checks, but the issue stayed closed after a commenter noted the standalone check-libs command and broader requested checks were still missing.
stealth/space-bunny-alpha — closed stale Partly implemented by #2252 (3118189c), which added upload-time library warnings; the reporter said the standalone check-libs command remained missing, leaving the full request unresolved.
qwen3.6-35b-a3b-mtp-q6 — — Partially implemented and merged via PR #2252, adding library checks during packaging. The author disputes closure, noting the requested standalone check-libs command remains unimplemented.
qwen/qwen3.6-35b-a3b — — Closed despite author disagreement. PR #2252 implemented pack and upload warnings for library synchronization but omitted the requested standalone check-libs command. The feature remains partially implemented and effectively abandoned.
qwen/qwen3.6-35b-a3b — — Closed and superseded by #2252, which implemented pack/upload warnings for library sync. The requested standalone check-libs command remains unimplemented, with contributors disputing the closure as incomplete.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #2252, which added libs checks during packaging. A contributor disputed the closure, noting the PR only partially addressed the request by omitting a standalone check-libs command for CI and general use.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#2252 (confidence 100%)

    Merged as 3118189c; added warnings when local charm libraries are newer than Store versions.

  • Related To: canonical/charmcraft#417 (confidence 100%)

    Explicitly linked by the maintainer as the related proposal to check for library updates.

Related issues

Issue Project State Summary Similarity
#2252 feat(upload): warn when uploading a charm if it has newer local libs charmcraft merged Merged as commit 3118189c, PR #2252 adds upload warnings when a charm’s local libraries are newer than store versions and fixes #213.
74%
#2034 fix(store): nicer error message when getting nonexistent libs charmcraft merged Merged PR #2034 (commit c9b51038), fixing #1754 by replacing Charmhub's unclear missing-library response with a clearer fetch-libs error.
70%