← Back to issue list

fix: remove the storage 'shared' field

View original Github issue

Metadata

Project
charmcraft
Number
#2205
Type
pull request
State
merged
Author
tonyandrewmeyer
Labels
—
Created
Updated
Closed

Current evaluation

Merged charmcraft#2205 as be3c6110, removing the never-implemented storage `shared` field after approval by two reviewers.

Resolution: closed resolved

Reason: PR #2205 was merged into Charmcraft as commit be3c6110, deleting the unimplemented `shared` storage field.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR removes the `shared` field from `storage`, as it has apparently never been implemented, so doesn't actually do anything. [Juju ticket](https://warthogs.atlassian.net/browse/JUJU-7562)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2205 as be3c6110, removing the never-implemented storage `shared` field after approval by two reviewers.
stealth/space-bunny-alpha — closed resolved Merged PR #2205 as commit be3c6110, removing the unimplemented storage `shared` field for JUJU-7562. Two reviewers approved it.
stealth/space-bunny-alpha — closed resolved Merged PR removed the unused storage `shared` field, its schema definition, and related test/serialization code, resolving JUJU-7562. Maintainers approved despite unrelated lint issues.
qwen/qwen3.6-35b-a3b — — Merged removal of the unused storage shared field, which was never implemented. Approved by two reviewers, passed CI, and changed 9 files. Resolves Juju ticket JUJU-7562.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the unused and unimplemented shared field from storage configuration. Addresses Juju ticket JUJU-7562, approved by maintainers, and bypassed unrelated lint checks prior to final merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1888 fix: lock shared cache directory charmcraft merged Merged PR #1888 in commit 4cce11b0, locking Charmcraft's shared cache to prevent concurrent-build cache races; fixes #1845.
70%