← Back to issue list

build(build-deps): install cargo if not installed

View original Github issue

Metadata

Project
charmcraft
Number
#2266
Type
pull request
State
open
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Adds 3 lines to Makefile to install cargo if missing, needed for non-AMD64/ARM64 CI runners. Change is already present in current Makefile (lines 90-91), making this a no-op. Maintainer raised unaddressed questions about pkg-config and per-arch conditionals 286 days ago.

Suggested action: close stale

Reason: The exact 3-line change (ifeq which cargo / APT_PACKAGES += cargo / endif) is already present in the current Makefile at lines 90-91, so merging would be a no-op. Additionally, maintainer sergiusens asked on 2025-04-24 about pkg-config, per-architecture conditionals, and resource cost, none of which were addressed in the 286 days since.

Impact: 15 Quick Win: 13.5 Staleness: 75 Complexity: 10 Confidence: 85

Issue body

This installs cargo if it's not installed already. This is needed for CI runners that aren't AMD64 or ARM64 for cryptography.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 15
Quick Win: 13.5
Staleness: 75
Complexity: 10
Confidence: 85
close stale Adds 3 lines to Makefile to install cargo if missing, needed for non-AMD64/ARM64 CI runners. Change is already present in current Makefile (lines 90-91), making this a no-op. Maintainer raised unaddressed questions about pkg-config and per-arch conditionals 286 days ago.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 15
Confidence: 90
close stale Proposes installing cargo for non-AMD64/ARM64 CI runners. Currently inactive for 245 days, has failing CI checks, and contains unanswered reviewer feedback questioning the implementation approach.
qwen3.6-35b-a3b-mtp-q6
Staleness: 68
Complexity: 15
Confidence: 65
needs review Adds conditional cargo installation for non-AMD64/ARM64 CI runners to support cryptography builds. Currently awaiting clarification on architectural concerns and alternative installation methods raised by a reviewer.
qwen3.6-35b-a3b-mtp-q6
Staleness: 70
Complexity: 15
Confidence: 65
needs review Adds conditional cargo installation for non-AMD64/ARM64 CI runners. Currently awaiting feedback on architecture-specific installation, pkg-config dependencies, and alternative Python apt approaches.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 15
Confidence: 85
close stale Adds conditional cargo installation for non-AMD64/ARM64 CI runners to support cryptography. Under discussion after a reviewer suggested the python apt route instead, questioning pkg-config needs and test resource usage. Awaiting maintainer response.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.