← Back to issue list

Add `charmcraft lint` to enforce Canonical recommendations

View original Github issue

Metadata

Project
charmcraft
Number
#2374
Type
issue
State
open
Author
taurus-forever
Labels
—
Created
Updated
Closed
—

Current evaluation

Feature request for `charmcraft lint` to enforce naming conventions. Maintainer acknowledged; naming linter exists via `charmcraft analyse`, but dedicated lint command and error severity pending LinterService refactor (#2546).

Suggested action: keep open

Reason: Maintainer @lengau acknowledged the request and linked it to #2315, whose continuation #2546 remains open. The naming-conventions linter already exists (added in PR #1487) and runs via `charmcraft analyse`, but the requested `lint` command and error-blocking severity are not yet implemented.

Evaluated by: mr-cal-bot

Impact: 40 Quick Win: 12 Complexity: 50 Confidence: 75 Actionability: 60

Issue body

### What needs to get done Hi, TL;DR: charm must follow same approach in naming actions/options/...: use `-` or `_` (c) Jon/codestyle. When developers adding the same feature to the different charms, they are following muscle memory and often missing this point. It cause issues like: https://warthogs.atlassian.net/browse/DPE-7741 (which is expensive and annoying to fix). Proposal add `charmcraft lint` to help charmers control it on CI/CD. E.g. it can check consistency of `_`/`-` and error blocking divergence. We can also warn this on `charmcraft pack`, but without error nobody notice it on CI. Tnx! ### Why it needs to get done To settle the high standards in charms quality avoiding divergences.

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest
Impact: 40
Quick Win: 12
Complexity: 50
Confidence: 75
Actionability: 60
keep open Feature request for `charmcraft lint` to enforce naming conventions. Maintainer acknowledged; naming linter exists via `charmcraft analyse`, but dedicated lint command and error severity pending LinterService refactor (#2546).
qwen/qwen3.6-35b-a3b
Impact: 40
Quick Win: 10
Complexity: 50
Confidence: 75
Actionability: 50
keep open Feature request to add `charmcraft lint` command for enforcing naming conventions. Acknowledged by maintainers but blocked on issue #2315, which was closed as abandoned. Not yet implemented.
qwen/qwen3.8-27b
Impact: 35
Quick Win: 19
Staleness: 55
Complexity: 45
Confidence: 72
Support Request: 10
keep open Feature request for a charmcraft lint command to enforce naming convention consistency (hyphens vs underscores) in actions/options. The NamingConventions linter already exists via charmcraft analyse (PR #1487), but a dedicated lint command and pre-linting during pack are not yet implemented. Maintainer acknowledged, blocked on #2315 which is now closed/abandoned.
qwen/qwen3.6-35b-a3b
Staleness: 65
Complexity: 55
Confidence: 85
Support Request: 10
keep open Proposal to add a charmcraft lint command to enforce naming conventions and improve charm quality. Acknowledged by maintainers as a future goal, pending resolution of related linting infrastructure work.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 50
Confidence: 85
Support Request: 10
keep open Proposal to add a charmcraft lint command enforcing naming conventions. Maintainer acknowledged interest and linked implementation to blocking issue 2315.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 65
Confidence: 90
Support Request: 10
keep open Proposal to add a charmcraft lint command to enforce naming conventions and improve charm quality. Maintainers acknowledged the request and confirmed it is planned, pending resolution of related issue #2315.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2315 (confidence 90%)

    Explicitly linked by maintainer in the issue comment as the prerequisite for pre-linters; closed without implementation.

  • Related To: canonical/charmcraft#1487 (confidence 85%)

    Merged PR (commit 01661572) that added the existing naming-conventions linter checking hyphen vs underscore consistency.

  • Blocked By: canonical/charmcraft#2546 (confidence 70%)

    Open continuation of #2315, tracking the Craft Application LinterService refactor that the lint command depends on.

Related issues

No related issues found above the similarity threshold.