← Back to issue list

fix(templates): improve explanation of how to manage library dependencies

View original Github issue

Metadata

Project
charmcraft
Number
#2557
Type
pull request
State
merged
Author
dwilding
Labels
Created
Updated
Closed

Current evaluation

Merged improvements to pyproject.toml dependency management documentation for kubernetes and machine profiles. Updates align with the new recommendation to distribute libraries as Python packages. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

This PR improves the explanation of how to manage library dependencies in `pyproject.toml` for the `kubernetes` and `machine` profiles. The improvement is needed because we now recommend that libraries be distributed as Python packages. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] ~I've added or updated any relevant documentation.~ - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged improvements to pyproject.toml dependency management documentation for kubernetes and machine profiles. Updates align with the new recommendation to distribute libraries as Python packages. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged an external contribution updating pyproject.toml templates for kubernetes and machine profiles. Changes clarify library dependency management to align with the new recommendation to distribute libraries as Python packages.
qwen3.6-35b-a3b-mtp-q6 Merged an external contribution updating pyproject.toml templates for kubernetes and machine profiles. The changes clarify library dependency management to align with the new recommendation to distribute libraries as Python packages.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2545 fix(templates): match 'uv add' order of lint fields in pyproject.toml charmcraft merged Merged a fix updating pyproject.toml field ordering in kubernetes and machine profiles to align with uv add, preventing unnecessary diffs. Approved by two reviewers and merged after CI validation.
74%
#378 build: fix a couple pieces of base pyproject starbase merged Merged after passing CI and approvals. Updated pyproject.toml to replace the deprecated license classifier with an SPDX identifier, switched the dynamic README reference from rST to markdown, and cleaned up whitespace.
72%
#215 fix: use correct README in pyproject.toml craft-store merged Merged a one-line fix to pyproject.toml that corrects the README reference, resolving issue #214. Approved by two reviewers and passed CI checks.
71%