ty CI fails for me
Metadata
Current evaluation
External PR CI no longer fails when the ty workflow cannot comment: PR #2662 (commit ca1d431f) made comment reporting non-fatal.
Resolution: closed resolved
Reason: Merged PR #2662, commit ca1d431f, separated ty checking from PR commenting and allowed reporting failures to continue, preventing fork PR token permission errors from failing CI.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### Check existing issues
- [x] I've verified that this bug isn't described by any existing issues.
### Bug description
[Experimental workflows / typecheck-with-ty (pull_request)](https://github.com/canonical/charmcraft/actions/runs/23733385590/job/69132061913?pr=2618) Failing after 25s
### Steps to reproduce
Open a pull request
### Environment
GHA
### charmcraft.yaml
```yaml
none
```
### Log output
```shell
Run if ty check 2>&1 > /home/runner/work/_temp/ty.log; then
if ty check 2>&1 > /home/runner/work/_temp/ty.log; then
echo '# Type checking with `ty` succeeded! 🎉🎉🎉' > /home/runner/work/_temp/comment.txt
else
echo 'Type checking with `ty` failed. This is a notification only and does not require action.' > /home/runner/work/_temp/comment.txt
fi
echo "<details><summary>Command output</summary>" >> /home/runner/work/_temp/comment.txt
echo -e '\n' >> /home/runner/work/_temp/comment.txt
cat /home/runner/work/_temp/ty.log >> /home/runner/work/_temp/comment.txt
echo '' >> /home/runner/work/_temp/comment.txt
echo "</details>" >> /home/runner/work/_temp/comment.txt
gh pr comment 2618 --body-file /home/runner/work/_temp/comment.txt
shell: /usr/bin/bash -e {0}
env:
UV_PYTHON_INSTALL_DIR: /home/runner/work/_temp/uv-python-dir
UV_CACHE_DIR: /home/runner/work/_temp/setup-uv-cache
GH_TOKEN: ***
GraphQL: Resource not accessible by integration (addComment)
Error: Process completed with exit code 1.
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | External PR CI no longer fails when the ty workflow cannot comment: PR #2662 (commit ca1d431f) made comment reporting non-fatal. | |
| stealth/space-bunny-alpha | — | closed resolved | External-PR ty CI failures were fixed by merged PR canonical/charmcraft#2662 (commit ca1d431f), preventing missing comment permissions from failing the workflow. | |
| stealth/space-bunny-alpha | — | closed stale | Closed without a recorded fix; the ty workflow failed when its GitHub integration lacked permission to add the informational PR comment. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed by #2662 (ca1d431f): external-PR ty checks were separated from commenting, and comment failures were made nonfatal to avoid fork-token permission errors. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without resolution. The CI workflow failed due to insufficient GitHub integration permissions preventing PR comments. Likely abandoned or resolved by adjusting workflow permissions. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without comments or resolution. The workflow failed due to a GitHub Actions permission error blocking PR comments. Likely abandoned or resolved by adjusting workflow permissions. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed as likely abandoned. The report details a GitHub Actions workflow failure caused by a missing repository permission for PR comments. No code changes or maintainer resolution were applied. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed due to GitHub integration permission error preventing PR comments. Likely abandoned or resolved by updating workflow permissions. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/charmcraft#2662
(confidence 99%)
Commit ca1d431f makes failed informational comments non-fatal for external pull requests.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2662 fix: prevent typecheck_with_ty workflow from failing on external PRs | charmcraft | merged | Merged PR #2662 (commit ca1d431f) split the typecheck_with_ty workflow into a 'Run ty' step and a 'Report as a comment' step with continue-on-error, so fork PRs no longer fail CI on read-only token addComment errors. |