← Back to issue list

fix(Project): get metadata from the correct project dir

View original Github issue

Metadata

Project
charmcraft
Number
#2644
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2644, commit c87eca0d, fixed metadata lookup to use the selected project directory, resolving #2493; the fix was slated for 4.2.1.

Resolution: closed resolved

Reason: PR #2644 was approved and merged as commit c87eca0d. It explicitly fixes #2493 by making metadata lookup honor --project-dir, working around a craft-application limitation; the fix was confirmed for 4.2.1.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This works around a limitation in craft-application where _app_preprocess_project can't get the project file. Fixes #2493 CRAFT-670 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2644, commit c87eca0d, fixed metadata lookup to use the selected project directory, resolving #2493; the fix was slated for 4.2.1.
stealth/space-bunny-alpha — closed resolved PR #2644 (commit c87eca0d) merged: ProjectService now tracks the real project dir in a module global so _app_preprocess_project reads metadata from it, fixing packing with a separate metadata.yaml and --project-dir. Workaround for craft-application (CRAFT-670).
stealth/space-bunny-alpha — closed resolved Merged PR #2644 (commit c87eca0d) fixed metadata lookup with --project-dir by reading from the correct project directory, working around a craft-application limitation. Resolves #2493 (CRAFT-670).
qwen/qwen3.6-35b-a3b — — Merged to fix metadata retrieval from the correct project directory, working around a craft-application limitation. Resolves #2493 and CRAFT-670. Approved by two reviewers and passed CI checks. Non-blocking type checker warnings were noted.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix to retrieve project metadata from the correct directory, working around a craft-application limitation. Resolves #2493 and CRAFT-670. Type-checking warnings were informational and did not block the merge.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2493 (confidence 100%)

    PR #2644 explicitly states that it fixes #2493; the merged change corrects metadata handling for a separate project directory.

Related issues

Issue Project State Summary Similarity
#22 meta: update metadata, incl. some dependencies craft-application merged Merged PR #22 as commit 70c38a12, updating project metadata and selected dependencies across four files.
71%