← Back to issue list

fix: correctly get project name for remote builds

View original Github issue

Metadata

Project
charmcraft
Number
#2681
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged after three approvals. Corrects project name retrieval for remote builds, resolving #2598. Integrated despite non-blocking type-checking warnings and two unresolved review comments.

Suggested action:

No scores available.

Issue body

Fixes #2598. CHARMCRAFT-690 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after three approvals. Corrects project name retrieval for remote builds, resolving #2598. Integrated despite non-blocking type-checking warnings and two unresolved review comments.
qwen3.6-35b-a3b-mtp-q6 Merged to resolve issue #2598 by correctly retrieving the project name for remote builds. The changes were successfully integrated despite non-blocking type checker notifications.
qwen3.6-35b-a3b-mtp-q6 Merged fix for correctly retrieving the project name during remote builds (#2598). The ty type checker reported non-blocking warnings, but the changes were approved and merged by maintainer bepri.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#351 fix(remotebuild): use full project name in log files craft-application merged Merged a fix ensuring remote build log files use the full project name, resolving issue #4781. Approved by three reviewers, passed CI, and updated two files.
83%
#4432 fix(remote-build): improve logging and catch exceptions snapcraft merged Merged pull request improving remote build logging and exception handling. Approved by reviewers, passed CI checks, and resolves issue #4399.
76%
#5748 fix: get the project from the project service every time snapcraft merged Merged a fix ensuring the project is retrieved from the project service on every call. Approved by two reviewers, the change modifies one file (+9/-1 lines) and resolves the retrieval logic despite one failing CI test.
74%
#623 fix: remove --status from remote-build overview craft-application merged Removed the non-existent --status argument from the remote-build overview text, resolving #620 and CRAFT-4028. Merged following three approvals and passing CI checks, with the branch retargeted to main.
73%
#4480 fix(remote): return error when remote build failed snapcraft merged Successfully merged fix for remote build failures that returns proper errors, resolving issue #4142. Approved by three reviewers with maintained code coverage across 13 files.
73%
#293 feat(remote-build): allow a user-provided project craft-application merged Merged after two approvals. Enables commands to set a user-provided project for remote builds without additional protections. Changes modify six files (+169/-12). Two unresolved review comments were noted before merge.
72%
#1561 fix(spread): workaround for remote builds getting the same name charmcraft merged Merged a three-line workaround to prevent remote builds from receiving duplicate names. Approved by two reviewers and integrated into the codebase.
72%
#2642 remote-build: detect early build errors snapcraft merged Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied.
72%
#5715 test: update remote-build artifact name snapcraft merged Merged after two reviewer approvals. Updates the expected filename for a remote-build spread test to fix a minor test mismatch. Passed all required CI checks and involved a single-line change.
71%
#1546 feat: remote build command charmcraft merged Merged the remote build command feature. Approved by two reviewers and passing CI, the PR rebases prior work and adds remote build functionality. Follow-up issues were created to resolve related build-id recovery and dependency bugs.
71%