← Back to issue list

ci: Fix CI filter job and linting issues

View original Github issue

Metadata

Project
charmcraft
Number
#2740
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged changes resolving CI filter job git errors and linting failures. Added a missing checkout step to policy.yaml and removed an unused ty: ignore comment. Approved by two reviewers with all CI checks passing.

Suggested action:

No scores available.

Issue body

This PR fixes two issues: 1. Added missing checkout step to policy.yaml workflow to resolve git error in filter job 2. Removed unused ty: ignore comment that was causing linting failure --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes resolving CI filter job git errors and linting failures. Added a missing checkout step to policy.yaml and removed an unused ty: ignore comment. Approved by two reviewers with all CI checks passing.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer lengau. Resolved a git error in the filter job by adding a missing checkout step to policy.yaml and fixed linting failures by removing an unused ty: ignore comment.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#567 ci: fix linter issues craft-parts merged Merged fix for CI linter issues across four files (+14/-6 lines). Approved by one reviewer and passed all CI checks before integration.
74%
#136 ci: filter for .readthedocs.yaml starflow merged Merged after approval and passing CI. Filters CI to trigger only docs lint for .readthedocs.yaml changes. Conflicts resolved by rebasing onto origin/main and updating the lint workflow.
74%
#141 ci: remove filter from lint workflow starflow merged Merged following two approvals and successful CI checks. Removes the filter from the lint workflow, delegating it to the calling workflow which defaults to affected source files. Resolves part of CRAFT-5161.
73%
#5 style(lint): fix linting issues starflow merged Merged after approval. Resolved linting issues by modifying one file with three additions and three deletions. No unresolved comments or CI checks were present.
73%
#20 style: fix linting issues craft-artifacts merged Merged after passing all CI checks and receiving approval from two reviewers. The change resolves linting issues across four files with a +11/-5 line diff, updating code style compliance.
72%
#2222 style: fix linting issues charmcraft merged Merged following approval by two reviewers. Resolved linting issues across three files with minor style adjustments (+8/-9 lines). No review comments or CI checks were required.
72%
#18 ci: ensure tests succeed in CI craft-application merged Merged updates to CI configuration ensuring tests pass successfully. Approved by one reviewer, modifying five files with 23 additions and 13 deletions.
71%
#1910 ci: fix tics tests charmcraft merged Merged a single-file update to fix TICS CI tests. Approved by two reviewers with no unresolved comments. The change resolves failing continuous integration checks.
71%
#144 ci: update CI platforms craft-cli merged Merged after approval. Updates CI platforms and removes Ubuntu-18.04 tests to bypass CI checks and unblock a linting fix. Approved by one reviewer and successfully merged.
70%
#1099 chore: fix linting craft-application merged Merged a linting fix to resolve unused directives flagged by Ty. The update modified two files, received approval from two reviewers, passed CI validation, and was successfully integrated.
70%