← Back to issue list

feat(paas): add validation for paas-config.yaml and metrics_path format

View original Github issue

Metadata

Project
charmcraft
Number
#2825
Type
pull request
State
merged
Author
alithethird
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 89b8168b, adding 12-factor paas-config.yaml validation requiring metrics-path to be a string and a URL path beginning with '/'.

Resolution: closed resolved

Reason: PR #2825 was merged as commit 89b8168b. It added validation for paas-config.yaml metrics_path format, with unit tests, and received approval from two reviewers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

For 12-factor charms add validation for `metrics_path` in `paas-config.yaml` file. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 89b8168b, adding 12-factor paas-config.yaml validation requiring metrics-path to be a string and a URL path beginning with '/'.
stealth/space-bunny-alpha — closed resolved Merged PR #2825 as commit 89b8168b, adding paas-config.yaml validation for the metrics_path format in 12-factor charms.
stealth/space-bunny-alpha — closed resolved Merged #2825 as commit 89b8168b, adding 12-factor paas-config.yaml validation requiring metrics-path to be a string and a valid URL path beginning with '/'.
stealth/space-bunny-alpha — — PR merged as commit 89b8168b, adding paas-config.yaml metrics-path validation (string type + URL path regex starting with '/') in charmcraft/extensions/app.py for 12-factor charms, with unit tests in tests/extensions/test_app.py.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#2825, adding metrics_path format validation for 12-factor charms in paas-config.yaml.
qwen/qwen3.6-35b-a3b — — Merged after two reviewer approvals. Adds validation for the metrics_path format in paas-config.yaml, introducing 88 lines across two files to enforce 12-factor charm configuration standards.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 25
Confidence: 85
needs review Adds validation for metrics_path format in paas-config.yaml. Approved by 2 reviewers with 0 unresolved comments. CI shows minor failures in slow/minimum dependency tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 20
Confidence: 90
needs review Adds validation for metrics_path in paas-config.yaml for 12-factor charms. Approved by two reviewers with zero unresolved comments. CI shows mixed results with several failing snap and slow tests.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 25
Confidence: 85
needs review Adds validation for metrics_path format in paas-config.yaml. Currently approved by two reviewers with zero unresolved comments. Several CI jobs are failing, requiring maintainer assessment before merge.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 25
Confidence: 90
needs review Adds validation for metrics_path format in paas-config.yaml for 12-factor charms. Currently approved by one reviewer, CI checks are passing or pending, with no unresolved comments.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 20
Confidence: 90
needs review Adds validation for metrics_path format in paas-config.yaml for 12-factor charms. Currently awaiting maintainer review with CI checks passing or pending.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 15
Confidence: 90
needs review Introduces validation for metrics_path format in paas-config.yaml. Currently awaiting maintainer review with CI checks passing or pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 25
Confidence: 90
needs review Adds validation for metrics_path format in paas-config.yaml. Currently awaiting initial maintainer review with CI checks still running.

Update history

Date Change
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#2596 feat: paas-config.yaml validation charmcraft merged Merged in #2596 via commit f1df851b, adding paas-config.yaml checks to reject invalid YAML and unsupported JSON framework logging formats during packing.
75%