← Back to issue list

Smoother and safer template project from init command.

View original Github issue

Metadata

Project
charmcraft
Number
#283
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged updates to charmcraft init that prevent publishing charms with leftover TEMPLATE-TODO markers. Validation was moved from build to upload per reviewer feedback. Fixes #237, #238, #243, and #247.

Suggested action:

No scores available.

Issue body

This involves several details: - Do NOT build the charm if the project has leftover TODOs from when it was bootstrapped with `init` . - For that, started to use `TEMPLATE-TODO` to make it very distinct. - Added a couple of those to different places where the developer also needs to pay attention. - Left the templates in an state that will create a "solid" charm project. Fixes #237, #238, #243 and #247.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged updates to charmcraft init that prevent publishing charms with leftover TEMPLATE-TODO markers. Validation was moved from build to upload per reviewer feedback. Fixes #237, #238, #243, and #247.
qwen3.6-35b-a3b-mtp-q6 Merged updates to charmcraft init that block uploads instead of builds when TEMPLATE-TODO markers remain. This prevents publishing incomplete charms while allowing local development. Resolves #237, #238, #243, #247.
qwen3.6-35b-a3b-mtp-q6 Enhances charmcraft init templates with TEMPLATE-TODO markers to block publishing incomplete charms. Validation shifted from build to upload time. Merged, resolving #237, #238, #243, #247. Interactive init features deferred.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1477 fix(templates): use more explicit __init__ param types in charm templates charmcraft merged Merged following two approvals and passing CI. Updated charm templates to use explicit __init__ parameter types, enhancing type safety and allowing direct framework usage in observe calls. Modified 3 files (+10/-10 lines).
72%
#1010 Update tox.ini in `charmcraft init` template charmcraft merged Merged after approval by two reviewers. Updates the tox.ini configuration in the charmcraft init template, modifying two files with 33 additions and 31 deletions.
72%
#295 Update charm library template for correct command to publish or update libraries charmcraft merged Merged a fix to update the charm library template with the correct command, replacing the non-existent charmcraft push-lib. Approved by two reviewers with minimal changes.
72%
#2351 fix(templates): update out-of-date parts in template README files charmcraft merged Merged update to kubernetes and machine template README files. Replaced metadata.yaml with charmcraft.yaml, updated package naming, and fixed documentation links. Approved by three reviewers and merged.
70%
#1012 Fix typo in CONTRIBUTING.md in `charmcraft init` template charmcraft merged Merged a typo correction in CONTRIBUTING.md for the charmcraft init template. Approved by one reviewer, the change was applied despite unrelated CI failures reported by the external contributor.
70%
#395 Update the default bundle from `charmcraft init` charmcraft merged Merged after reviewer approval and conflict resolution. Updates the charmcraft init default bundle with improved metadata examples, splits developer instructions to CONTRIBUTING.md, and clarifies README setup steps.
70%
#91 First pass at 'charmcraft init' charmcraft merged Merged the initial 'charmcraft init' implementation. Approved by two reviewers, the PR adds 1087 lines across 24 files to scaffold charms. README.md, additional options, and interactive prompts require future updates.
70%