← Back to issue list

chore(profiles): remove MODEL_SETTINGS from all tox.ini templates

View original Github issue

Metadata

Project
charmcraft
Number
#2852
Type
pull request
State
open
Author
dwilding
Labels
Created
Updated
Closed

Current evaluation

Removes MODEL_SETTINGS passthrough from 14 tox.ini template files across all init profiles. Approved, all CI passing, ready to merge.

Suggested action: needs review

Reason: PR has 1 approval, 0 unresolved review comments, and all CI checks passing. The change is a small, clean removal of unused MODEL_SETTINGS from 14 tox.ini template files (+0/-14 lines). Ready for maintainer merge.

Impact: 25 Quick Win: 23.75 Staleness: 10 Complexity: 5 Confidence: 85

Issue body

This PR removes the `MODEL_SETTINGS` passthrough from `tox.ini` of **all profiles** (normally I only update the `kubernetes` and `machine` profiles). Per https://github.com/canonical/operator/issues/2652, I don't believe there's any value in keeping `MODEL_SETTINGS` around. I don't think we need to mention anything in the Charmcraft release notes.

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 25
Quick Win: 23.75
Staleness: 10
Complexity: 5
Confidence: 85
needs review Removes MODEL_SETTINGS passthrough from 14 tox.ini template files across all init profiles. Approved, all CI passing, ready to merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 90
needs review Removes MODEL_SETTINGS passthrough from all profile tox.ini templates. Approved by one reviewer, CI passing, awaiting final merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Removes MODEL_SETTINGS passthrough from tox.ini templates across all profiles. Changes are passing CI, awaiting maintainer review, and referenced a related issue.

Update history

Date Change
updated
created

Related issues

No related issues found above the similarity threshold.