test(plugins): split package install command tests
Metadata
Current evaluation
Splits test_get_package_install_commands into focused unit tests across python, poetry, and uv plugins with a shared conftest fixture. Fresh PR with 0 reviewers and 1 unresolved review comment.
Suggested action: needs review
Reason: The PR is fresh (10 days old) and addresses open issue #2849, but has 0 reviewers and 1 unresolved review comment, indicating it needs maintainer attention before merging.
Impact:
20
Quick Win:
17.0
Staleness:
10
Complexity:
15
Confidence:
75
Issue body
## Description
Splits `test_get_package_install_commands` in the plugin unit tests into focused tests, one behaviour each, as discussed in #2849.
### Changes:
- Add `tests/unit/parts/plugins/conftest.py` with a `make_plugin` factory fixture and copy-command helpers, replacing the plugin construction duplicated across the three files.
- In `tests/unit/parts/plugins/test_python.py`, split the test into pip options, build-subdir resolution, copy commands per existing directory, and parent-directory exclusion.
- Apply the same split to `test_poetry.py` and `test_uv.py`.
- Replace `pytest_check` soft checks with plain `assert` now that each test covers a single phase.
Fixes #2849
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
20
Quick Win:
17.0
Staleness:
10
Complexity:
15
Confidence:
75
|
needs review | Splits test_get_package_install_commands into focused unit tests across python, poetry, and uv plugins with a shared conftest fixture. Fresh PR with 0 reviewers and 1 unresolved review comment. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Splits plugin package install command tests into focused unit tests, adds shared fixtures in conftest.py, and replaces soft checks with plain asserts. Currently pending review with one unresolved comment and passing CI. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Splits plugin package install command tests into focused unit tests, adds shared fixtures in conftest.py, and replaces soft checks with standard asserts. Currently pending maintainer review with one unresolved comment and passing CI. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
85
|
needs review | Splits plugin package install tests into focused unit tests, adds shared fixtures in conftest, replaces soft checks with asserts. Currently awaiting maintainer review with CI passing. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Splits plugin package install command tests into focused unit tests, adds shared fixtures in conftest.py, and replaces soft checks with standard assertions. Currently awaiting maintainer review with passing CI. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
20
Confidence:
90
|
needs review | Splits plugin package install command tests into focused unit tests, introduces shared fixtures in conftest.py, and replaces soft assertions with standard asserts. Currently awaiting maintainer review with passing CI. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Likely Fixed By:
canonical/charmcraft#2849
(confidence 90%)
PR description explicitly states 'Fixes #2849', which is the open issue requesting this test refactoring.
Related issues
No related issues found above the similarity threshold.