← Back to issue list

chore: mark extension-provided endpoints as optional

View original Github issue

Metadata

Project
charmcraft
Number
#2869
Type
pull request
State
open
Author
wctaylor
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds `optional: true` to observability/ingress endpoints in framework charmcraft.yaml templates, addressing issue #2868. +156/-32 across 5 files; unit/lint CI green but 3 snap-tests fail and 1 review comment is unresolved, awaiting maintainer review.

Suggested action: needs review

Reason: The change is small and mechanical (5 files, +156/-32) and directly targets issue #2868, whose summary states "Maintainers support explicit optional metadata, but the source and corresponding tests have not yet been updated" — so the change direction is endorsed. However the PR shows "Review status: pending (0 reviewers)" with "Unresolved review comments: 1" and no activity for 25 days, and three snap-tests (ubuntu-22.04-64, ubuntu-25.10-64, ubuntu-20.04-64) are failing, so it is not merge-ready and needs a maintainer to confirm the failures are unrelated flakiness and address the outstanding comment. Tool access to the diff was unavailable (repo returned 'No pinned SHA available'), so correctness of the per-template edits could not be verified directly.

Evaluated by: mr-cal-bot

Impact: 45 Quick Win: 17 Complexity: 25 Confidence: 58 Actionability: 50

Issue body

This PR updates the extensions to mark the observability and ingress endpoints with `optional: true`. This addresses https://github.com/canonical/charmcraft/issues/2868 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 45
Quick Win: 17
Complexity: 25
Confidence: 58
Actionability: 50
needs review Adds `optional: true` to observability/ingress endpoints in framework charmcraft.yaml templates, addressing issue #2868. +156/-32 across 5 files; unit/lint CI green but 3 snap-tests fail and 1 review comment is unresolved, awaiting maintainer review.
stealth/space-bunny-alpha
Impact: 35
Quick Win: 16
Complexity: 18
Confidence: 91
Actionability: 55
needs review Marks observability and ingress endpoints optional in extension metadata; 16 CI checks pass, but three Ubuntu snap-test jobs fail. The related issue is open, no reviewers have participated, and one review comment remains unresolved.
qwen3.6-35b-a3b-mtp-q6
Impact: 50
Quick Win: 35
Staleness: 10
Complexity: 30
Confidence: 65
needs review Marks observability and ingress endpoints as optional in extensions, addressing issue #2868. Fresh PR with 0 reviews and some CI failures on older Ubuntu releases.
qwen3.6-35b-a3b-mtp-q6
Impact: 40
Quick Win: 34
Staleness: 0
Complexity: 15
Confidence: 85
needs review Marks observability and ingress endpoints in extensions as optional. Fresh PR with passing CI, no reviews yet, addresses open issue #2868.

Update history

Date Change
updated
updated
updated
created

Related work

  • Related To: canonical/charmcraft#2868 (confidence 95%)

    PR body explicitly states it addresses issue #2868 ('Mark optional endpoints as optional in extensions'), which is still open.

Related issues

Issue Project State Summary Similarity
#2868 Mark optional endpoints as optional in extensions charmcraft open Extension-generated charm metadata still omits optional: true for observability endpoints; maintainers support explicit values, but the open request remains unimplemented.
72%