← Back to issue list

Specify the resource type when uploading one.

View original Github issue

Metadata

Project
charmcraft
Number
#289
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged in charmcraft#289 via commit 38ad8199, adding explicit file resource types for uploads ahead of OCI-image support and improving help text in two commands.

Resolution: closed resolved

Reason: PR #289 was merged into master as commit 38ad8199. It updates uploads to include the resource type and corrects help output in two other commands.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This is because the API changed, specifying the type for files is optional (for now), but we will need it soon to indicate oci-image types. Also fixed/improved two help-related details in other commands.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in charmcraft#289 via commit 38ad8199, adding explicit file resource types for uploads ahead of OCI-image support and improving help text in two commands.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#289: uploads now specify resource types to accommodate API changes and future OCI image support; two other commands received help-text improvements.
qwen/qwen3.6-35b-a3b — — Merged after two approvals. Specifies resource types during uploads to align with API updates and prepare for oci-image support. Also improves help text in two other commands. (+59/-11 lines, 4 files changed)
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updates upload logic to explicitly specify resource types, aligning with API changes and preparing for oci-image support. Also corrects help text for two other commands.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#839 Upload resources on charmcraft upload when specified as upstream-resource in the metadata file charmcraft closed Feature request to auto-upload OCI resources during `charmcraft upload` was declined by design: maintainer refused to have Charmcraft copy Docker Hub images into Canonical's registry and cited upload inefficiency; user advised to script it using JSON output.
72%
#253 Support for resource uploading charmcraft merged Merged resource-uploading support in canonical/charmcraft#253 via commit f23482c8 and merge commit ed071757.
71%