← Back to issue list

test: add spread regression test for juju-controller pack

View original Github issue

Metadata

Project
charmcraft
Number
#2902
Type
pull request
State
open
Author
lengau
Labels
PR: Run Manual Spread
Created
Updated
Closed
—

Current evaluation

Maintainer-authored test-only PR adding juju-controller to the manual spread 'operator charms' pack matrix (with --platform pinning and deploy-skip) as a regression test for #2816. Open, 0 reviews, CI green except OSV-scanner.

Suggested action: needs review

Reason: Small, self-contained test-only diff (+23/-2) to an existing manual spread task file, authored by a maintainer (lengau) and already run manually with 'Successful tasks: 1'. CI is green on the relevant checks (predicate, validate-schema, diff-schema, CLA); only 'Security scan / OSV-scanner' is failing, which does not touch tests/spread YAML, and the unit/fast/slow test jobs are still pending. No reviewers have commented yet and one unresolved comment is outstanding, so it needs a maintainer pass before landing.

Evaluated by: mr-cal-bot

Impact: 18 Quick Win: 9 Complexity: 25 Confidence: 74 Actionability: 68

Issue body

## Summary Adds a spread regression test that packs the [juju-controller](https://github.com/juju/juju-controller) charm as part of the existing `tests/spread/charms/operator` suite, to guard against #2816 (AppArmor/apparmor_parser incompatibility between a Jammy build container and a newer host during `charmcraft pack`). ## Details - Added `CHARM/juju_controller` to the operator charms matrix in `tests/spread/charms/operator/task.yaml`. - juju-controller declares platforms for multiple Ubuntu bases (22.04, 24.04, 26.04) that all match the same architecture. Without an explicit `--platform`, charmcraft errors with `Multiple builds match the current platform`, so the test pins `--platform` to match the running system (`ubuntu@$(lsb_release -rs):$(dpkg --print-architecture)`). - Skips the generic `juju deploy` step for juju-controller, since Juju does not support manually deploying the controller charm (`ERROR manual deploy of the controller charm not supported`). ## Testing Ran the new task directly via: ``` spread -reuse -resend 'multipass:ubuntu-22.04-64:tests/spread/charms/operator:juju_controller' ``` Result: `Successful tasks: 1`. Confirmed the original #2816 AppArmor error does not reproduce — `charmcraft pack` completed cleanly for the jammy base. Closes #2816

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 18
Quick Win: 9
Complexity: 25
Confidence: 74
Actionability: 68
needs review Maintainer-authored test-only PR adding juju-controller to the manual spread 'operator charms' pack matrix (with --platform pinning and deploy-skip) as a regression test for #2816. Open, 0 reviews, CI green except OSV-scanner.
stealth/space-bunny-alpha
Impact: 22
Quick Win: 10
Complexity: 20
Confidence: 70
Actionability: 57
needs review Maintainer PR (+23/-2, 3 files) adds juju_controller to the spread operator charms matrix with explicit --platform pinning and a skipped deploy step, as a regression guard for #2816. Awaiting review; OSV-scanner fails, most test/spread checks still pending.

Update history

Date Change
updated
updated
updated
created

Related work

  • Related To: charmcraft#2816 (confidence 88%)

    The PR body explicitly states 'Closes #2816'; the linked issue is the open 'charmcraft pack fails on Ubuntu Resolute 26.04' AppArmor/apparmor_parser bug this test guards against.

Related issues

No related issues found above the similarity threshold.