← Back to issue list

ci(hotfix/2.7): use correct extras name for mypy tox environment

View original Github issue

Metadata

Project
charmcraft
Number
#2939
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Fixed CI lint job failure by correcting the mypy tox environment to use the existing type extra instead of the non-existent types extra. Merged in #2939.

Resolution: closed resolved

Reason: The PR was merged by maintainer lengau, fixing the tox configuration mismatch where tox.ini referenced a non-existent types extra. It now correctly uses the type extra defined in setup.py, allowing the CI lint job to run successfully.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Summary The Charmcraft 2.7 CI lint job fails in its "Configure environment" step, before any linter runs: ``` tox run -m lint --notest lint-mypy: failed with extras not found for package charmcraft: types (available: dev, lint, type) ``` `tox.ini` asks for the `types` extra, but `setup.py` only defines `dev`, `lint` and `type`. Because env creation fails, `tox run -e lint-mypy` never executes and the whole lint job errors out. This renames the extra to the one that actually exists. ## Test plan Verified locally with the tool versions CI pins: - `tox run -m lint --notest` creates all lint environments successfully. - `tox run -e lint-black,lint-ruff,lint-shellcheck,lint-codespell,lint-mypy` passes on all five linters. CI: `lint` job reaches the linters and passes. > [!WARNING] > Generated by an automated agent, not a human. 🤖 **BEEP BOOP I'M A TOASTER** _Model:_ `step-5-preview-free` _Harness:_ opencode CLI

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Fixed CI lint job failure by correcting the mypy tox environment to use the existing type extra instead of the non-existent types extra. Merged in #2939.

Update history

Date Change
merged
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#2929 fix(hotfix/2.7): use correct extras name for mypy tox environment charmcraft closed Fixes CI lint failure by correcting the mypy tox extra name from types to type. Superseded by a rebuilt PR on the same branch.
90%