← Back to issue list

snap: explicitly use requirements.txt for dependencies

View original Github issue

Metadata

Project
charmcraft
Number
#303
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #303 made the Charmcraft snap explicitly install dependencies from requirements.txt, via commit 17741dc7 and merge commit 83fbd200.

Resolution: closed resolved

Reason: PR #303 was approved by two reviewers and merged into the project. The change was committed as 17741dc7 and integrated by merge commit 83fbd200.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #303 made the Charmcraft snap explicitly install dependencies from requirements.txt, via commit 17741dc7 and merge commit 83fbd200.
stealth/space-bunny-alpha — closed resolved Merged #303 via commit 17741dc7 (merge 83fbd200), making the snap explicitly use requirements.txt for dependency installation.
stealth/space-bunny-alpha — closed resolved Merged PR #303 made the snap build explicitly use requirements.txt for dependency management after approval by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged after approval by two reviewers. The snap build now explicitly uses requirements.txt for dependency management, applying a minimal +2/-0 line change across one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to snap packaging that explicitly uses requirements.txt for dependency management. Applied by a maintainer without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#396 Recommend snap in the README. charmcraft merged Merged PR #396 (commit 90019231, merged as 1774741e) by maintainer facundobatista made a 3-line README edit recommending snap as the preferred install method for Charmcraft; approved by 2 reviewers.
71%
#470 [REGRESSION] charmcraft not installing dependencies from requirements.txt anymore charmcraft closed Fixed by merged PR #472 (commit 57b74577, "build: include venv in prime if charm-requirements defined"), which restored requirements.txt deps appearing in packed charms; maintainer closed after release in edge.
70%