← Back to issue list

Refactored the upload-resource command for it's new behaviour (CRAFT-240)

View original Github issue

Metadata

Project
charmcraft
Number
#391
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged #391 via bf2d2c5e, replacing Docker Hub handling with Canonical Registry reuse/upload and Charmhub JSON registration.

Resolution: closed resolved

Reason: PR #391 was merged as commit bf2d2c5e, with merge commit 77657028. It implements the new Canonical Registry reuse/upload flow and subsequent Charmhub JSON upload.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Now it will stop using Dockerhub, and the process will be: - check if the indicated digest is in Canonical's registry; if yes, use it - else try to upload it; the ImageHandler function will upload it and will return the new remote digest, in which case it will be used, or None, in which case an error will be presented to the user Once the command has the image's digest from the Canonical's Registry (because it was already there, or just uploaded), will request the formal JSON to Charmhub, which will be uploaded back to Charmhub as any other resource.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #391 via bf2d2c5e, replacing Docker Hub handling with Canonical Registry reuse/upload and Charmhub JSON registration.
stealth/space-bunny-alpha — closed resolved Merged PR #391 (commit bf2d2c5e): upload-resource now uses Canonical’s registry, reusing or uploading images and fetching Charmhub JSON instead of Dockerhub.
stealth/space-bunny-alpha — closed resolved Merged #391, replacing Docker Hub with Canonical’s registry: reuse existing digests or upload via ImageHandler before submitting the resource to Charmhub.
qwen/qwen3.6-35b-a3b — — Merged refactoring of the upload-resource command to replace Dockerhub with Canonical's registry and Charmhub. Approved by two reviewers, the update streamlines digest verification and resource uploads across three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring of the upload-resource command to drop Docker Hub. Checks Canonical's registry for image digests, uploads missing images, fetches Charmhub JSON, and completes the upload. Resolves CRAFT-240.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#253 Support for resource uploading charmcraft merged Merged resource-uploading support in canonical/charmcraft#253 via commit f23482c8 and merge commit ed071757.
73%