Isolated the linters/checkers, no more shared state between them (CRAFT-383).
Metadata
Current evaluation
Merged PR #460 isolated dependency and dependent checkers by removing shared metadata state; implemented in 7a555f64 and merged via 545418b7.
Resolution: closed resolved
Reason: PR #460 was approved and merged into main by commit 545418b7, with implementation in 7a555f64. Each checker now parses metadata independently, preventing an ignored or crashed checker from depriving another of required information.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is to avoid having problems when a "dependency checker" is ignored (or crashes), and then the "dependent checker" is missing the needed information.
The branch is big, but there's no really a change in functionality, I just:
- separated code into a function that is now used from two places
- parsed the metadata twice in two different places
- adapted all the tests
Note that this depends on [the previous branch](https://github.com/canonical/charmcraft/pull/455).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #460 isolated dependency and dependent checkers by removing shared metadata state; implemented in 7a555f64 and merged via 545418b7. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #460 isolated linters/checkers to prevent ignored or crashed dependency checkers from depriving dependent checkers of metadata. Implemented in 7a555f64 and merged by 545418b7. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that isolates linters and checkers to eliminate shared state, preventing failures when dependency checkers are ignored or crash. Approved by three reviewers, passed CI, and modified two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactoring that isolates linters and checkers by eliminating shared state, preventing dependency checker failures from breaking dependent checkers. Implementation splits code into reusable functions, duplicates metadata parsing, and updates tests, dependent on PR #455. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#455
(confidence 100%)
Explicit prerequisite PR adding the analyze command, merged in 9ac04412.
Related issues
No related issues found above the similarity threshold.