← Back to issue list

build: prime venv if charm-requirements defined (CRAFT-417)

View original Github issue

Metadata

Project
charmcraft
Number
#472
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged #472 in 6f167533 (implementation 57b74577), priming the venv when charm-requirements is defined and testing the property instead of the deprecated CLI switch.

Resolution: closed resolved

Reason: PR #472 was approved and merged. Commit 57b74577 added the venv priming fix and updated tests to use the charm-requirements property.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The command line switch to set requirements was deprecated in favor of using the `charm-requirements` property in the charm part. Test it instead of the command line variable. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #472 in 6f167533 (implementation 57b74577), priming the venv when charm-requirements is defined and testing the property instead of the deprecated CLI switch.
stealth/space-bunny-alpha — closed resolved Merged PR #472 primes the venv when charm-requirements is defined and replaces the deprecated command-line switch in tests (implementation commit 57b74577).
qwen/qwen3.6-35b-a3b — — Merged after approval. Updates tests to use the charm-requirements property instead of the deprecated command line switch for setting requirements.
qwen3.6-35b-a3b-mtp-q6 — — Merged a build update that replaces a deprecated command-line switch with the charm-requirements property for priming the virtual environment. Tests were updated accordingly to resolve CRAFT-417.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.