← Back to issue list

build: include optional license and icon files (CRAFT-436)

View original Github issue

Metadata

Project
charmcraft
Number
#485
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #485 (commit e8f34326, squashed 41ee6167) for CRAFT-436: charmcraft now packages optional LICENSE and icon.svg from the project dir into the built charm; fixes issue #482.

Resolution: closed resolved

Reason: The PR was approved and merged by maintainer cmatsuoka (merge commit e8f34326, squashed as 41ee6167), adding "LICENSE" and "icon.svg" to CHARM_OPTIONAL_FILES in charmcraft/const.py, still present at current HEAD. sergiusens noted it fixes #482.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add `LICENSE` and `icon.svg` to the list of files to be included in the charm, if they exist in the project directory. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #485 (commit e8f34326, squashed 41ee6167) for CRAFT-436: charmcraft now packages optional LICENSE and icon.svg from the project dir into the built charm; fixes issue #482.
stealth/space-bunny-alpha — closed resolved Merged PR #485 (commit e8f34326) for CRAFT-436, adding optional LICENSE and icon.svg files to built charms. It fixes #482.
qwen/qwen3.6-35b-a3b — — Merged. Updates the build to include optional LICENSE and icon.svg files in the charm if present. Approved by two reviewers, passed CI, and resolves #482. Confirmed CharmHub only supports SVG icons.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Includes optional LICENSE and icon.svg files in the charm build if present, resolving issue #482. SVG is confirmed as the only supported icon format for CharmHub.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: charmcraft#482 (confidence 97%)

    "Please include the LICENSE in the final charm by default" — closed by this merge, as stated in the PR comment by sergiusens.

Related issues

Issue Project State Summary Similarity
#482 Please include the LICENSE in the final charm by default charmcraft closed Fixed by #485 (commit 41ee6167), allowing LICENSE and icon.svg as optional files to be packaged into charms when present.
80%