← Back to issue list

make required files executable (CRAFT-501)

View original Github issue

Metadata

Project
charmcraft
Number
#521
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

PR #521 was merged as commit eecfdea3, adding a POSIX guard so required files are made executable only where executable bits and fchmod() are supported.

Resolution: closed resolved

Reason: Merged PR #521 added the requested POSIX check before changing file permissions, resolving Windows failures caused by unsupported executable-bit and fchmod operations.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Windows does not support executable bits or fchmod(). Check if system is posix before setting exe bit. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #521 was merged as commit eecfdea3, adding a POSIX guard so required files are made executable only where executable bits and fchmod() are supported.
stealth/space-bunny-alpha — closed resolved Merged PR #521 in commit eecfdea3 added a POSIX guard, avoiding unsupported executable-bit and fchmod operations on Windows.
stealth/space-bunny-alpha — closed resolved Merged a one-line POSIX guard to skip unsupported executable-bit and fchmod operations on Windows.
qwen/qwen3.6-35b-a3b — — Merged after implementing reviewer feedback to explicitly check for POSIX systems and add a flag for non-POSIX environments. Updated make_executable to enforce this and fixed the init command to correctly set permissions at build time.
qwen3.6-35b-a3b-mtp-q6 — — Merged after implementing reviewer feedback. Added explicit flag handling for non-POSIX systems in make_executable and updated the init command to pass the flag and re-apply permissions during packing, resolving Windows compatibility issues.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.